Problem/Motivation

As discussed on BEF module's #3500976 issue, BEF datepicker support days / months / years but not time entries. Since the jQuery UI datepicker they are using doesn't support time entries itself, and since Flatpickr does, it would be nice if the datetime_flatpickr_bef submodule could handle it.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#2 support-time-entry-in-bef-3501292-2.patch7.02 KBnagy.balint

Comments

macsim created an issue. See original summary.

nagy.balint’s picture

nagy.balint commented
Status: Active » Needs work
StatusFileSize
new support-time-entry-in-bef-3501292-2.patch7.02 KB

This will need more testing, but I got a first working version.

It has an issue where on first setup it throws an error, but then if the view is saved it works fine afterwards. Not sure why it does that.

I did not test it with min-max (2 date filter) yet, but tests run fine.

nagy.balint’s picture

nagy.balint commented

  • nagy.balint committed a2f4c6af on 3.0.x 
    Issue #3501292 by nagy.balint, macsim: Support time entries in...
nagy.balint’s picture

nagy.balint commented

It works with is between now too.

I leave it as needs work, because of the issue when enabling the plugin the first time.

macsim’s picture

macsim commented 
  - Syncing drupal/datetime_flatpickr (dev-3.0.x 9798387) into cache
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing drupal/datetime_flatpickr (dev-3.0.x 9798387): Cloning 9798387fdf from cache
  - Applying patches for drupal/datetime_flatpickr
    https://www.drupal.org/files/issues/2025-01-25/support-time-entry-in-bef-3501292-2.patch (Support time entries in FlatpickrDateBef filter plugin)
   Could not apply patch! Skipping. The error was: Cannot apply patch https://www.drupal.org/files/issues/2025-01-25/support-time-entry-in-bef-3501292-2.patch
nagy.balint’s picture

nagy.balint commented

I am not sure about the previous comment, as it is already committed see #4

I just left it open since BEF throws an error when it is initially added, maybe it is a BEF issue, not sure at this point.

macsim’s picture

macsim commented

My bad I saw the "needs work" status and the patch and didn't realised it was already merged to 3.0.x

nagy.balint’s picture

nagy.balint commented
Status: Needs work » Fixed

I will close it as completed, and it can be a follow up issue if this remaining BEF issue is problematic.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.