Calling Merge::key() with an array is removed in Drupal 11; cron crashes [#3500381]

Problem/Motivation

SimpleAdsCron::runAggregation() calls merge::key() and passes an array of field names and values. This argument was deprecated in Drupal 10.2 and removed in Drupal 11. Accordingly, on Drupal 11, cron crashes, causing no cron tasks to be run by the site.

Issue fork simpleads-3500381

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3500381-calling-mergekey-with changes, plain diff MR !2
Check out this branch for the first time

Check out existing branch, if you already have it locally
2.0.x compare
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

16 January 2025 at 20:57

danchadwick created an issue. See original summary.

Comment #2

16 January 2025 at 21:47

danchadwick opened merge request !2

Comment #3

robbnl commented 27 January 2025 at 17:42

Hi,
I believe I am running into the same issue.
After installing Simpleads three days ago cron stopped working.
The errors I get are:

TypeError: Cannot access offset of type array on array in Drupal\Core\Database\Query\Merge->key() (line 331 of ******************/core/lib/Drupal/Core/Database/Query/Merge.php)
#0 ******************/modules/contrib/simpleads/src/SimpleAdsCron.php(96): Drupal\Core\Database\Query\Merge->key()
#1 ******************/modules/contrib/simpleads/src/SimpleAdsCron.php(79): Drupal\simpleads\SimpleAdsCron->runAggregation()
#2 ******************/modules/contrib/simpleads/simpleads.module(69): Drupal\simpleads\SimpleAdsCron->init()
#3 ******************/core/lib/Drupal/Core/Cron.php(275): simpleads_cron()
#4 ******************/core/lib/Drupal/Core/Extension/ModuleHandler.php(307): Drupal\Core\Cron->Drupal\Core\{closure}()
#5 ******************/core/lib/Drupal/Core/Cron.php(258): Drupal\Core\Extension\ModuleHandler->invokeAllWith()
#6 ******************/core/lib/Drupal/Core/Cron.php(97): Drupal\Core\Cron->invokeCronHandlers()
#7 ******************/core/lib/Drupal/Core/ProxyClass/Cron.php(75): Drupal\Core\Cron->run()
#8 ******************/core/modules/automated_cron/src/EventSubscriber/AutomatedCron.php(65): Drupal\Core\ProxyClass\Cron->run()
#9 ******************/vendor/symfony/event-dispatcher/EventDispatcher.php(246): Drupal\automated_cron\EventSubscriber\AutomatedCron->onTerminate()
#10 ******************/vendor/symfony/event-dispatcher/EventDispatcher.php(206): Symfony\Component\EventDispatcher\EventDispatcher::Symfony\Component\EventDispatcher\{closure}()
#11 ******************/vendor/symfony/event-dispatcher/EventDispatcher.php(56): Symfony\Component\EventDispatcher\EventDispatcher->callListeners()
#12 ******************/vendor/symfony/http-kernel/HttpKernel.php(114): Symfony\Component\EventDispatcher\EventDispatcher->dispatch()
#13 ******************/core/lib/Drupal/Core/StackMiddleware/StackedHttpKernel.php(63): Symfony\Component\HttpKernel\HttpKernel->terminate()
#14 ******************/core/lib/Drupal/Core/DrupalKernel.php(683): Drupal\Core\StackMiddleware\StackedHttpKernel->terminate()
#15 ******************/index.php(22): Drupal\Core\DrupalKernel->terminate()
#16 {main}