Problem/Motivation

Fix deprecations in PHP 8.4

Issue fork field_group-3500119

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

acbramley created an issue. See original summary.

acbramley opened merge request !92

acbramley’s picture

acbramley commented
Status: Active » Needs review
pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Needs review » Reviewed & tested by the community

This applies to 3.x branch too.

pcambra’s picture

pcambra
he/him
Primary language Spanish
commented
Status: Reviewed & tested by the community » Needs review

Ah there were a couple missing

liam morland made their first commit to this issue’s fork.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

All tests are now passing except cspell and eslint.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Issue tags: +PHP 8.4
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

Most issues have been fixed in #3504453: Fix PHP 8.4.x deprecation and other warnings (PHPStan). The remaining changes should still be committed.

steinmb’s picture

steinmb commented

Should we block this issue on #3504453: Fix PHP 8.4.x deprecation and other warnings (PHPStan) that I think should be committed first?

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

The order doesn't much matter. The commit message for this one need to be changed, though. The nullable types issue has already been fixed.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Needs work

As of #11 - this is close to the finish line :)

acbramley’s picture

acbramley commented
Status: Needs work » Closed (outdated)

The original scope here was fixing implicit nullable deprecations which has already been done.

liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented

All that is left in the merge request is adding a return type declaration.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Closed (outdated) » Needs review

Nice, let's also solve that!

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
liam morland’s picture

liam morland
Primary language English
Location Ontario, CA 🇨🇦
commented
Title: Fix implicit nullables for PHP 8.4 » Add return type toFormatterHelper::formProcess()
anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Needs review » Reviewed & tested by the community

Great, thank you @liam morland!

  • grevil committed e702e034 on 4.x authored by acbramley 
    Issue #3500119 by liam morland, acbramley, pcambra, anybody: Add return...
grevil’s picture

grevil commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.