[2.x] Seeds Toolbar

Thank you for applying!

Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.

The important notes are the following.

• If you have not done it yet, you should run phpcs --standard=Drupal,DrupalPractice on the project, which alone fixes most of what reviewers would report.
• For the time this application is open, only your commits are allowed.
• The purpose of this application is giving you a new drupal.org role that allows you to opt projects into security advisory coverage, either projects you already created, or projects you will create. The project status won't be changed by this application and no other user will be able to opt projects into security advisory policy.
• We only accept an application per user. If you change your mind about the project to use for this application, or it is necessary to use a different project for the application, please update the issue summary with the link to the correct project and the issue title with the project name and the branch to review.

To the reviewers

Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.

The important notes are the following.

• It is preferable to wait for a Code Review Administrator before commenting on newly created applications. Code Review Administrators will do some preliminary checks that are necessary before any change on the project files is suggested.
• Reviewers should show the output of a CLI tool only once per application.
• It may be best to have the applicant fix things before further review.

For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.

1. Fix phpcs issues.

phpcs --standard=Drupal,DrupalPractice --extensions=php,module,inc,install,test,profile,theme,css,info,txt,md,yml seeds_toolbar/

FILE: seeds_toolbar/seeds_toolbar.libraries.yml
-------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
-------------------------------------------------------------------------------
 16 | ERROR | [x] Expected 1 newline at end of file; 0 found
-------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
-------------------------------------------------------------------------------

FILE: seeds_toolbar/seeds_toolbar.module
------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
------------------------------------------------------------------------
 446 | ERROR | Doc comment is empty
------------------------------------------------------------------------

FILE: seeds_toolbar/assets/css/seeds-toolbar-rtl.css
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  87 | ERROR | [x] Multiple selectors should each be on a single line
  93 | ERROR | [x] Multiple selectors should each be on a single line
 118 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: seeds_toolbar/assets/css/seeds-toolbar.css
--------------------------------------------------------------------------------
FOUND 65 ERRORS AFFECTING 54 LINES
--------------------------------------------------------------------------------
  93 | ERROR | [x] Multiple selectors should each be on a single line
  93 | ERROR | [x] Multiple selectors should each be on a single line
 103 | ERROR | [x] Multiple selectors should each be on a single line
 106 | ERROR | [x] Multiple selectors should each be on a single line
 106 | ERROR | [x] Multiple selectors should each be on a single line
 106 | ERROR | [x] Multiple selectors should each be on a single line
 106 | ERROR | [x] Multiple selectors should each be on a single line
 106 | ERROR | [x] Multiple selectors should each be on a single line
 115 | ERROR | [x] Multiple selectors should each be on a single line
 118 | ERROR | [x] Multiple selectors should each be on a single line
 126 | ERROR | [x] Multiple selectors should each be on a single line
 142 | ERROR | [x] Multiple selectors should each be on a single line
 180 | ERROR | [x] Multiple selectors should each be on a single line
 180 | ERROR | [x] Multiple selectors should each be on a single line
 183 | ERROR | [x] Multiple selectors should each be on a single line
 183 | ERROR | [x] Multiple selectors should each be on a single line
 206 | ERROR | [x] Multiple selectors should each be on a single line
 206 | ERROR | [x] Multiple selectors should each be on a single line
 206 | ERROR | [x] Multiple selectors should each be on a single line
 297 | ERROR | [x] Multiple selectors should each be on a single line
 412 | ERROR | [x] Multiple selectors should each be on a single line
 473 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 480 | ERROR | [x] Multiple selectors should each be on a single line
 492 | ERROR | [x] Multiple selectors should each be on a single line
 496 | ERROR | [x] Multiple selectors should each be on a single line
 500 | ERROR | [x] Multiple selectors should each be on a single line
 507 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 5
 508 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 509 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 512 | ERROR | [x] Multiple selectors should each be on a single line
 516 | ERROR | [x] Multiple selectors should each be on a single line
 520 | ERROR | [x] Multiple selectors should each be on a single line
 547 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 548 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 550 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 551 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 554 | ERROR | [x] Multiple selectors should each be on a single line
 571 | ERROR | [x] Multiple selectors should each be on a single line
 574 | ERROR | [x] Multiple selectors should each be on a single line
 574 | ERROR | [x] Multiple selectors should each be on a single line
 574 | ERROR | [x] Multiple selectors should each be on a single line
 577 | ERROR | [x] Multiple selectors should each be on a single line
 601 | ERROR | [x] Multiple selectors should each be on a single line
 605 | ERROR | [x] Multiple selectors should each be on a single line
 608 | ERROR | [x] Multiple selectors should each be on a single line
 644 | ERROR | [x] Multiple selectors should each be on a single line
 647 | ERROR | [x] Multiple selectors should each be on a single line
 683 | ERROR | [x] Multiple selectors should each be on a single line
 700 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 704 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 723 | ERROR | [x] Multiple selectors should each be on a single line
 727 | ERROR | [x] Multiple selectors should each be on a single line
 751 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 753 | ERROR | [x] Multiple selectors should each be on a single line
 771 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 821 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 822 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 824 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 825 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 842 | ERROR | [x] Multiple selectors should each be on a single line
 846 | ERROR | [x] Multiple selectors should each be on a single line
 860 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 6
 861 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 872 | ERROR | [x] Line indented incorrectly; expected 2 spaces, found 10
 917 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 65 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

FILE: seeds_toolbar/seeds_toolbar.permissions.yml
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 6 | ERROR | [x] Expected 1 newline at end of file; 0 found
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

2. FILE: README.md

The README file is missing the required sections, including Requirements, Installation, and Configuration.

3. FILE: seeds_toolbar.module

/**
 * @file
 * Contains seeds_toolbar.module.
 */

The usual description for a .module file is Hook implementations for the [module name] module. where [module name] is the module name given in the .info.yml file.

4. FILE: templates/seeds-add-menu.html.twig

<ul class="{{menu_name}}">
    {% for item in items %}
        <li class="seeds-item">
            {{item}}
        </li>
    {% endfor %}
</ul>

FILE: templates/seeds-add.html.twig

{% if search %}
    <div class="seeds-toolbar-search-container">
        <input placeholder="{{'Search...' | t}}" class="seeds-toolbar-add-search" />
    </div>
{% endif %}
{% if content_links is not empty %}
    <h2 class="seeds-heading">{{content_collection}}</h2>
    {{content_links}}
{% endif %}
{% if taxonomy_links is not empty %}
    <h2 class="seeds-heading">{{taxonomy_collection}}</h2>
    {{taxonomy_links}}
{% endif %}
{% if media_links is not empty %}
    <h2 class="seeds-heading">{{media_collection}}</h2>
    {{media_links}}
{% endif %}
{% if block_links is not empty %}
    <h2 class="seeds-heading">{{block_collection}}</h2>
    {{block_links}}
{% endif %}

FILE: templates/seeds-toolbar-help.html.twig

<ul>
<li>Choose between light or dark mode</li>

<li>Change Drupal logo to your website logo</li>

<li>Add your helpdesk link and leave it empty to hide it.</li>

<li>Load custom css style.</li>
</ul>

<ul>
<li>Responsive Preview</li>

<li>Coffee</li>

<li>Devel</li>

<li>Block Content Permissions</li>

<li>Masquerade</li>

<li>Menu Link Attributes</li>

<li>Tour UI</li>

<li>Acquia connector</li>
</ul>

FILE: templates/seeds-toolbar-menu.html.twig and templates/seeds-toolbar.html.twig

Twig code needs to be correctly indented. Drupal uses two spaces for indentation, not four spaces or tabs.

5. FILE: templates/seeds-toolbar-help.html.twig

Strings shown in the user interface must be translatable. That holds true also for strings used in template files.

6. FILE: src/SeedsManager.php

  /**
   * Constructor.
   */
  public function __construct($language_manager, $current_user, $entity_type_manager, $module_handler, $config_factory) {

The documentation comment for constructors is not mandatory anymore, If it is given, the description must be Constructs a new [class name] object. where [class name] includes the class namespace.

All Twig files are still improperly indented. Ensure that two spaces are used for indentation instead of four spaces or tabs.

Rest looks fine to me.

Let’s wait for a Code Review Administrator to take a look and if everything goes fine, you will get the role.

Thank you for your contribution and for your patience with the review process!

I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.

These are some recommended readings to help you with maintainership:

• Dries' post on Responsible maintainers
• Maintainership
• Git version control system
• Issue procedures and etiquette
• Maintaining and responding to issues for a project
• Release naming conventions.

You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank the dedicated reviewers as well.