Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.no functional change just a code style fix
| Comment | File | Size | Author |
|---|---|---|---|
| services_code_style.patch | 3.42 KB | Pasqualle | |
Comments
Comment #1
XanoKudos on the patch, but there is more than a few bits of whitespace that needs to be fixed. Also, You may never review your own patch ;-)
Quote from #354243: Coding standards:
Comment #2
PasqualleI mostly put the issue into RTBC status where there is no functional change, as there is nothing really to review..
I used the coder module to fix the code style so I don't know what I missed..
Incorrect code style is a bug and it is far from critical.
Comment #3
XanoIt is not a bug since the code works as intended. It is just something that needs to be done and for people to properly maintain this module it needs to be done quickly and well. Therefore I marked it as a critical task. Since 'code style' isn't a term the Drupal project uses, but 'coding standards' is, this issue should be named such, also because redundant white space should be removed according to the coding standards. Please leave this issue set to 'task' unless you are absolutely certain that following the coding standards causes this module to be buggy.
Comment #4
Pasquallesearch for code style
The wrong code style in modules prevents me to contribute. So I consider it as an annoying bug, but you can leave it on task if you prefer..
Can we concentrate on the issue, and why it is in 'code needs work' status?
Comment #5
XanoOkay, you're right. I guess the non-official term is code style then.
I have set the patch status to 'patch (code needs work)', because I thought this issue could deal with the whole coding standards problem. I took a quick peek at the code last night and I believe there were some more problems than the ones you addressed.
Comment #6
marcingy CreditAttribution: marcingy commented