Hi,

The Gin Admin Theme have released their 4.x branch but we cannot update to it until this module supports it in its composer requirements.

Is there a plan to get support for this in?

It seems one of the breaking changes introduced in the Gin Admin Theme 4.x branch is switching the css class name styles to match core (from camel case to kebab) - https://www.drupal.org/project/gin/issues/3309113

Thanks, Neil

Issue fork gin_lb-3498755

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

altcom_neil created an issue. See original summary.

joelpittet made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Priority: Normal » Major

I think this is important now, as it blocks update to latest versions. Thanks!

shivam_tiwari made their first commit to this issue’s fork.

shivam_tiwari opened merge request !100

shivam_tiwari’s picture

shivam_tiwari commented
Status: Active » Needs review
christian.wiedemann’s picture

christian.wiedemann commented

Hi,
I am not sure if we have more breaking changes with the 4.x branch of gin. I checked it right now and it looks "good" for me.
But maybe you have more expierence. Should I create a new 2.0.x branch to support gin 4? What do you think?

kmonty’s picture

kmonty
He/Him
Location Berlin, DE + SF, CA
commented

I think it would be helpful to create a 2.x branch, even if it is in alpha state, so folks can test it more. Given the scope of published breaking changes, I don't see a reason that gin_lb wouldn't be compatible as-is.

I was going to spend some time testing this today, as there some issues with the sticky nav and our Layout Builder setup that we are encountering, but we cannot even upgrade to the latest release of Gin without manually hacking our composer lockfile.

mpotter’s picture

mpotter commented

I definitely support creating a new branch so this change can be merged and then tested since people can't really apply a patch to a module's composer.json.

The alternative would be to update the main 1.x-dev branch with a more complex composer.json requirement that would allow gin_lb to be installed with either gin 3.x OR 4.x if you don't expect a lot of needed changes.

christian.wiedemann’s picture

christian.wiedemann commented
Status: Needs review » Fixed

Thanks! I created a new branch and merged.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented

Thank you very much @christian.wiedemann! :) Happy to give it a try.

steinmb’s picture

steinmb commented

Thank you :)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

miltonqp’s picture

miltonqp commented

Thank you

christian.wiedemann’s picture

christian.wiedemann commented