Overview

A user should be able to scroll the layers menu if they are dragging an item to a different layer. This works on chrome, but doesn't on Firefox. The preview canvas scrolls instead. See gif.

Proposed resolution

The standard behavior would be for the layers menu to be scrollable while a user is dragging a layers menu item.

See gif:

User interface changes

CommentFileSizeAuthor
cant-scroll.gif123.85 KBhooroomoo
can-scroll.gif177.05 KBhooroomoo
#3 0fe0008a3ce345f69f4e3463bba06d4a.gif1.31 MBomkar-pd
#4 firefox-layers-drag.gif2.89 MBhooroomoo
#13 firefox-scroll-issue.gif925.93 KBdrupalbabaji

Issue fork experience_builder-3498598

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

hooroomoo created an issue. See original summary.

parthbcharya made their first commit to this issue’s fork.

omkar-pd’s picture

omkar-pd commented
StatusFileSize
new 0fe0008a3ce345f69f4e3463bba06d4a.gif1.31 MB

Currently, it scrolls while dragging in the layers menu.

cant scroll

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
StatusFileSize
new firefox-layers-drag.gif2.89 MB

@omkar-pd Are you using chrome?

Looks like it works on Chrome after testing it, but I just tested it on Firefox (my default browser) and it looks like the preview canvas is receiving the drag event and not the layers menu so the preview is scrolling instead of the layers menu.

firefox

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: Add scrolling on drag in the layers menu » Scrolling on drag in layers menu doesn't work in Firefox
Issue summary: View changes
Issue tags: +stable blocker
omkar-pd’s picture

omkar-pd commented

Yes, @hooroomoo, I'm using chrome.

Let me test this in Firefox.

parthbcharya’s picture

parthbcharya commented
Assigned: Unassigned » parthbcharya
Status: Active » Needs work

parthbcharya opened merge request !809

parthbcharya’s picture

parthbcharya commented
Status: Needs work » Needs review
wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: parthbcharya » hooroomoo
hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Title: Scrolling on drag in layers menu doesn't work in Firefox » [PP-1] Scrolling on drag in layers menu doesn't work in Firefox
Status: Needs review » Postponed

Marking as postponed on #3520438: Refactor Layers UI to use DnDKit as it is possible it might be solved by that, or not to waste anyones effort if another fix is needed after the move to dnd kit

hooroomoo’s picture

hooroomoo
they/them
Location nyc🗽
commented
Assigned: hooroomoo » Unassigned
drupalbabaji’s picture

drupalbabaji commented
StatusFileSize
new firefox-scroll-issue.gif925.93 KB

Dev tested on local dev enviornment with branch 'layers-dndkit' of issue https://www.drupal.org/project/experience_builder/issues/3520438 . Issue is not reproducible on firefoxfirefox scroll on drag issue

jessebaker’s picture

jessebaker commented
Status: Postponed » Closed (outdated)

Closing this as it's no longer an issue once #3520438: Refactor Layers UI to use DnDKit lands.