Problem/Motivation

Current pipeline phpcs errors:

FILE: ...y/web/modules/custom/section_library/src/Form/AddTemplateToLibraryForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 103 | ERROR | [x] Parameter $section_storage has null default value, but is
     |       |     not marked as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
FILE: ...ry/web/modules/custom/section_library/src/Form/AddSectionToLibraryForm.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 103 | ERROR | [x] Parameter $section_storage has null default value, but is
     |       |     not marked as nullable.
     |       |     (SlevomatCodingStandard.TypeHints.NullableTypeForNullDefaultValue.NullabilityTypeMissing)
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------
Time: 231ms; Memory: 6MB
PHP CODE SNIFFER REPORT SUMMARY
--------------------------------------------------------------------------------
FILE                                                            ERRORS  WARNINGS
--------------------------------------------------------------------------------
...custom/section_library/src/Form/AddSectionToLibraryForm.php  1       0
...ustom/section_library/src/Form/AddTemplateToLibraryForm.php  1       0
--------------------------------------------------------------------------------
A TOTAL OF 2 ERRORS AND 0 WARNINGS WERE FOUND IN 16 FILES

Issue fork section_library-3497763

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jastraat created an issue. See original summary.

jastraat opened merge request !35

jastraat’s picture

jastraat commented
Status: Active » Needs review
solideogloria’s picture

solideogloria commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +PHP 8.4

This is required for PHP 8.4 compatibility to avoid deprecation errors.

  • jastraat committed 8318ff1d on 1.2.x 
    Issue #3497763 by jastraat, solideogloria: Fix PHPCS...
jastraat’s picture

jastraat commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.