Problem/Motivation

Part of the work to enable DrupalPractice.Objects.GlobalFunction

Steps to reproduce

Proposed resolution

Enable sniff for tests 

<include-pattern>*/tests/*</include-pattern>

Use t() only when needed for testing translations.

Remaining tasks

Postponed on #3497403: Fix DrupalPractice.Objects.GlobalFunction in system test modules

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3497405

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !10802

quietone’s picture

quietone commented
Title: Fix DrupalPractice.Objects.GlobalFunction in remaining test moduleses » Fix DrupalPractice.Objects.GlobalFunction in tests
Issue summary: View changes
Status: Postponed » Active
quietone’s picture

quietone commented
Status: Active » Needs review
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented
Status: Needs review » Reviewed & tested by the community

This is great, I love that we're able to remove so many calls to t.

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Reviewed & tested by the community » Needs work

merge conflict

Anonymous’s picture

Anonymous (not verified) commented

akulsaxena made their first commit to this issue’s fork.

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs work » Needs review

Resolved the Merge conflicts and rebased.
Pipeline is all green now!

borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
commented

Pipelines are green again after the rebase, looks good to me.

smustgrave made their first commit to this issue’s fork.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Rebased so I could re-run the test failures. They were all random.

Believe the 1 open thread has been answered

  • catch committed 9a030ab9 on 11.x 
    Issue #3497405 by quietone, nod_: Fix DrupalPractice.Objects....
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 11.x, thanks!

catch closed merge request !10802

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.