Invalid hit details link

@kongkx while installing the module i am getting this error - Error: Class "DeviceDetector\ClientHints" not found in Drupal\visitors\Service\DeviceService->getDeviceDetector()

@sourabhsisodia_,

I think you did not use composer to install visitors. You need to use composer.

@kongkx,

Which report has the bad link? I am having trouble reproducing the error.

I am not able to reproduce the error. Which version of Vistitors are you using?

Maybe replace the active visitors view, with the one in config/optional ?

Seeing the same problem, resetting status to "needs work"

When I go to the page visitors/hits, all detail links are shown as follows when you hover over them: visitors/hits/1,115
(note the comma)

when you then click on the link, you get this URL: visitors/hits/1%2C115
and the page itself shows only the title "View access log" and no other data.

When I manually correct the link to: /visitors/hits/1115
then the pages shows up OK.

It seems, somehow the link builder takes some sort of number-formatter that inserts a thousand marker as "," (comma) into the link.

PS: This only started when there were more than 1000 hits. Before that, a hit like 988 would show OK.

Which version of Visitors are you using?

Currently using 8.x-2.31

Thank you @hoporr,

I think the reason I was not able to reproduce the error is this was "fixed", but a hook_update_N was not created.

Have you been using Visitors long or recently?

I will take a look at this again.

Yes, I have been using Visitors long on several sites. On this smaller site it is actually monitored, almost daily, and that is why the error was found.

I merged an update to the dev branch.

If you confirm it resolved the issue for you, I will make a new release.

I tested the fix, and it does not resolve the issue, see details below.
I tried to reset this issue to "needs work" but the system does not let me...

I tested on latest core 10.6.1, both on windows and the final linux-server:

1) I installed the dev branch as mentioned above, and it did not fix.
2) I installed the latest release version 8.x-32, and rand the patch against that, and it did not fix the issue.

When I ran the updates, I did notice an update hook that ran, I checked the patch and it seems to come from that patch:
visitor 8232 hook_update_n 8232 - Fixes separator for visitor_ids field in recent_view_table and referrer_table.

So it seems the update ran, the code is there, but I still get the same behavior:

In the list of recent hits, I these links when I hover over it: ..../visitor/hits/2,011
and then when I click I get this in the URL and it does not load: visitors/hits/2%2C011, which causes an empty page