Deprecate and replace entity_test_create_bundle(), entity_test_delete_bundle()

This one I actually have some concern on. Clearly it's used throughout core so probably a fair assumption it could be in contrib. So this would immediately break people's tests.

Brought this up in #core-development and @larowlan agreed this probably needs to be deprecated as there are lot of usages in contrib

https://git.drupalcode.org/search?group_id=2&scope=blobs&search=%22entit...

It's not a hook, it's just a function, we can follow normal deprecation rules here and add the deprecation message to the function.

You can look at this MR for examples: https://git.drupalcode.org/project/drupal/-/merge_requests/10309/diffs

And this documentation https://www.drupal.org/about/core/policies/core-change-policies/how-to-d...
If you've not done it before the message has a specific structure so copying and updating is most likely the easiest way forward.

You'll also need a CR for the message so you'll want to create one before doing that so you have the link.

Let me know if you have any other questions, it's unfortunate that this one is trickier than the other conversions, but it's used a lot so this makes sense.

Deprecations are the most common way to do this, we've only been able to skip that for these conversions because they are test modules.

Technically in this case we don't have to deprecate because tests are not api and don't need deprecation, but since this used by a ton of contrib we make an exception and deprecate in order to notify contrib and custom code they need to update.

You can open an issue in https://www.drupal.org/project/rector to create a rule for this, but that will still require the deprecation.
If you don't want to do this I can take this one back on, let me know!

Agreed, entity_test is a widely used test module as it is enabled by default with \Drupal\KernelTests\Core\Entity\EntityKernelTestBase, so IMHO that basically makes it an API for tests, which is also covered by BC.

Would be deprecated in 11.2 removed in 12

Since 11.1 is already out

That’s a fine title.

I went through everything, looks great two suggestions that need to be applied.

CR looks great short and to the point.

I can rtbc once the suggestions are applied.

Looks good to me now.

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

This one had a couple of conflicts, rebased though should be ready for review.

Rebase looks good to me, properly merged with the now existing EntityTestHelper class.

#7 mentions deprecation messages. Reading the comments I am not sure if it was decided they would not be required? I do not see any such messages in the MR: see 'Proposed resolution' in the issue summary.

Both functions are deprecated: https://git.drupalcode.org/project/drupal/-/merge_requests/10678/diffs#1...

@nicxvan Thanks. Great. I was scrolling forever through the code : )

Committed/pushed to 11.x, thanks!