Before fixing the issue:

before

CommentFileSizeAuthor
#10 Log-in.png38.75 KBkanchan bhogade
#7 after.png87.2 KBsayan_k_dutta
#4 After.png39.96 KBkanchan bhogade
#4 Before.png196.15 KBkanchan bhogade
#3 after.png153.73 KBalok_singh
before.png416.28 KBalok_singh

Issue fork bootstrap_cloud-3495770

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alok_singh created an issue. See original summary.

alok_singh opened merge request !53

alok_singh’s picture

alok_singh commented
Assigned: alok_singh » Unassigned
Status: Active » Needs review
StatusFileSize
new after.png153.73 KB

After fixing the issue.

after

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new Before.png196.15 KB
new After.png39.96 KB

Hi
I've tested MR! 53 on Drupal 10.3.x
The MR is applied cleanly...

The Login page error is resolved.

Screenshots

RTBC+1

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Title: On Login page getting an error, needs to be fixed. » Fix an error on the login page
Issue summary: View changes
Status: Needs review » Needs work

@alok_singh

Thank you for supplying the patch. I posted my comments. Can you please check the ones? Thanks!

sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: Unassigned » sayan_k_dutta

Working on it.

sayan_k_dutta’s picture

sayan_k_dutta commented
Assigned: sayan_k_dutta » Unassigned
Status: Needs work » Needs review
StatusFileSize
new after.png87.2 KB

Made the changes. Verified working fine.
Please review.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sayan_k_dutta

Thank you for the update. I posted my comments. Thanks

sayan_k_dutta’s picture

sayan_k_dutta commented
Status: Needs work » Needs review

Made the changes requested.

kanchan bhogade’s picture

kanchan bhogade commented
StatusFileSize
new Log-in.png38.75 KB

Tested Updated MR !53 on Drupal 10.3.x
MR applied successfully...

Tested manually, the login page error is fixed

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Needs review » Needs work

@sayan_k_dutta

Thank you for the update. Sorry, I gave you a wrong suggestion. Can you please take a look at my comment? Thanks

sayan_k_dutta’s picture

sayan_k_dutta commented
Status: Needs work » Needs review

@yas changes done.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Needs work

@sayan_k_dutta, Thank you for the patch. I have one comment. Can you please check it out.

sayan_k_dutta’s picture

sayan_k_dutta commented
Status: Needs work » Needs review

Made the requested change. Please review.

baldwinlouie’s picture

baldwinlouie commented
Status: Needs review » Reviewed & tested by the community

@sayan_k_dutta , thank you for the patch. It looks good to me now. Moving to RTBC.

yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented

@sayan_k_dutta

Thank you for the update.

@baldwinlouie

Thank you for your review. I’ll merge the patch into 6.x and 7.x; and close this issue as Fixed.

  • yas committed ee4891d7 on 7.x authored by alok_singh 
    Issue #3495770 by alok_singh, sayan_k_dutta, yas, kanchan bhogade,...

  • yas committed 21519bb8 on 6.x authored by alok_singh 
    Issue #3495770 by alok_singh, sayan_k_dutta, yas, kanchan bhogade,...
yas’s picture

yas
🇯🇵 he/him
Primary language Japanese
Location California 🇺🇸
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.