Problem/Motivation
Follow-up from #3494908: Set skip procedural scanning for all modules in core. Let's make the changes we need to make to mark the remaining modules.
Modules that implement hooks that cannot be converted we use the #[StopProceduralScan] Attribute.
This is for system.
Steps to reproduce
N/A
Proposed resolution
Add #[StopProceduralScan] Attribute to modules that have hook_requirements, hook_hook_info or hook_module_implements_alter
Move procedural hooks to top of files that must remain
If there is not already a services file create it
Remaining tasks
N/A
User interface changes
N/A
Introduced terminology
N/A
API changes
N/A
Data model changes
N/A
Release notes snippet
N/A
Issue fork drupal-3495507
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3495507-system-move-procedural
changes, plain diff MR !10645
Comments
Comment #3
nicxvan commentedComment #4
dwwThis was already RTBC before it was split up. I’m busy this weekend, but hope to look on Monday to confirm this is still ready.
Comment #5
smustgrave commentedReviewed the changes and they all make sense.
the system.theme.inc MAY be out of scope but personally think it's fine here. Will see what the committer thinks .
Comment #6
nicxvan commentedComment #7
larowlanLeft a couple of questions on the MR - thanks
Comment #8
nicxvan commentedLet's postpone this for a bit on #3495943: Handle module preprocess functions as OOP hooks
Comment #9
nicxvan commentedComment #10
larowlanblocker is in
Comment #11
berdirI'd suggest we keep this postponed on #3518903: Convert template preprocess in system.module
Comment #12
nicxvan commentedComment #13
nicxvan commentedSorry didn't read last comment
Comment #14
nicxvan commentedThis is outdated since we got the bulk conversion.
Since it's one line per module I'm going to retarget the meta.