Problem/Motivation

Follow-up from #3494908: Set skip procedural scanning for all modules in core. Let's make the changes we need to make to mark the remaining modules.
Modules that implement hooks that cannot be converted we use the #[StopProceduralScan] Attribute.
This is for system.

Steps to reproduce

N/A

Proposed resolution

Add #[StopProceduralScan] Attribute to modules that have hook_requirements, hook_hook_info or hook_module_implements_alter
Move procedural hooks to top of files that must remain

If there is not already a services file create it

Remaining tasks

N/A

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3495507

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

Status: Active » Needs review
dww’s picture

This was already RTBC before it was split up. I’m busy this weekend, but hope to look on Monday to confirm this is still ready.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Reviewed the changes and they all make sense.

the system.theme.inc MAY be out of scope but personally think it's fine here. Will see what the committer thinks .

nicxvan’s picture

Title: System move procedural hooks and mark as converted » Mark System module procedural hooks as converted
larowlan’s picture

Status: Reviewed & tested by the community » Needs review

Left a couple of questions on the MR - thanks

nicxvan’s picture

Status: Needs review » Postponed
Related issues: +#3495943: Handle module preprocess functions as OOP hooks
nicxvan’s picture

Title: Mark System module procedural hooks as converted » [pp-1] Mark System module procedural hooks as converted
larowlan’s picture

Title: [pp-1] Mark System module procedural hooks as converted » Mark System module procedural hooks as converted
Status: Postponed » Active

blocker is in

berdir’s picture

Status: Active » Postponed

I'd suggest we keep this postponed on #3518903: Convert template preprocess in system.module

nicxvan’s picture

Status: Postponed » Needs work
nicxvan’s picture

Status: Needs work » Postponed

Sorry didn't read last comment

nicxvan’s picture

Status: Postponed » Closed (outdated)

This is outdated since we got the bulk conversion.

Since it's one line per module I'm going to retarget the meta.