Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
file system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
21 Dec 2024 at 23:57 UTC
Updated:
6 Jan 2025 at 21:39 UTC
Jump to comment: Most recent
.module files are only necessary when there are preprocess functions now that almost all hooks can be OOP
Open file
Move const to an enum:
FILE_URL_TEST_CDN_1
FILE_URL_TEST_CDN_2
Move file_test_get_return to FileTestHooks because it is only called by that one hook.
Move everything else to FileTestHelper
Delete file_test_validator it is not called anywhere.
None
N/A
N/A
N/A
N/A
N/A
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #3
nicxvan commentedComment #4
nicxvan commentedComment #5
nicxvan commentedComment #6
nikolay shapovalov commentedThanks for your MR, can you please check my feedback?
Comment #7
nicxvan commentedI will address this.
Comment #8
nicxvan commentedThis is ready again, I fixed the name, we don't need to worry about BC for test functions.
Comment #9
nikolay shapovalov commentedThanks for update. Please check my feedback.
Let's decide about type hinting and add information to Meta.
Comment #10
nicxvan commentedAddressed comments and applied one suggestion.
Comment #11
nikolay shapovalov commentedThanks, lgtm.
Comment #14
larowlanCommitted to 11.x, thanks folks