Problem/Motivation

.module files are only necessary when there are preprocess functions now that almost all hooks can be OOP

Steps to reproduce

Open file

Proposed resolution

Move const to an enum:
FILE_URL_TEST_CDN_1
FILE_URL_TEST_CDN_2

Move file_test_get_return to FileTestHooks because it is only called by that one hook.

Move everything else to FileTestHelper

Delete file_test_validator it is not called anywhere.

Remaining tasks

None

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3495499

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Issue summary: View changes
nicxvan’s picture

Status: Active » Needs review
nikolay shapovalov’s picture

Status: Needs review » Needs work

Thanks for your MR, can you please check my feedback?

nicxvan’s picture

I will address this.

nicxvan’s picture

Status: Needs work » Needs review

This is ready again, I fixed the name, we don't need to worry about BC for test functions.

nikolay shapovalov’s picture

Status: Needs review » Needs work

Thanks for update. Please check my feedback.
Let's decide about type hinting and add information to Meta.

nicxvan’s picture

Status: Needs work » Needs review

Addressed comments and applied one suggestion.

nikolay shapovalov’s picture

Status: Needs review » Reviewed & tested by the community

Thanks, lgtm.

  • larowlan committed 804d8a0c on 11.x
    Issue #3495499 by nicxvan, nikolay shapovalov: Move helpers in file_test...

larowlan’s picture

Status: Reviewed & tested by the community » Fixed

Committed to 11.x, thanks folks

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.