Problem/Motivation

We added the settings to the main monitoring settings page and not the separate settings form, but didn't remove the route for it, so that's still there.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork monitoring-3495372

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

berdir created an issue. See original summary.

kul.pratap’s picture

kul.pratap commented
Assigned: Unassigned » kul.pratap

Working on it.

kul.pratap’s picture

kul.pratap commented

I can't reproduce this issue because the routing.yml file contains only one route for the settings form, and I can't find any other separate settings form with a route.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Yes, and that one settings form is the problem. This module doesn't have separate settings form. It doesn't work, MonitoringPrometheusSettingsForm doesn't exist.

kul.pratap’s picture

kul.pratap commented

@berdir Thanks for your reply.

If MonitoringPrometheusSettingsForm doesn't exist and there is no route defined for it, I can only find a single route for MonitoringSettingsForm and if we remove that then setting form doesn't show. Considering the issue summary mentions removing the broken route, what should be our next step?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

The other route is dynamically defined in the the routing event subscriber. The next step is removing routing.yml completely.

kul.pratap opened merge request !26

kul.pratap’s picture

kul.pratap commented
Assigned: kul.pratap » Unassigned
Status: Active » Needs review

@berdir i have removed the broken route from monitoring_prometheus.routing.yml
Please review
Thank You

  • berdir committed 589ae609 on 8.x-1.x authored by kul.pratap 
    Issue #3495372 by kul.pratap, berdir: Remove broken settings route
berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs review » Fixed

Merged, thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.