Problem/Motivation

Currently there are not scheduled pipelines for the project which makes it tricky when contributing to know if your change has brought about failures, or if they are pre existing.

I believe the tests are currently failing due to the --verbose option being removed without replacement (https://github.com/sebastianbergmann/phpunit/issues/5647)

If one of the maintainers can please create a scheduled pipeline for the 2.1.x branch? See https://project.pages.drupalcode.org/gitlab_templates/info/common/ for steps

Issue fork address-3495167

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

ericgsmith created an issue. See original summary.

ericgsmith opened merge request !58

ericgsmith’s picture

ericgsmith commented
Title: [Gitlab] PHPUnit tests fail after --verbose removed, and no scheduled pipelines exist » [Gitlab] Tests fail with PHPUnit 10 after verbose removed, and no scheduled pipelines exist
Issue summary: View changes
ericgsmith’s picture

ericgsmith commented
Title: [Gitlab] Tests fail with PHPUnit 10 after verbose removed, and no scheduled pipelines exist » [Gitlab] Tests fail with PHPUnit 10 after verbose removed / scheduled pipelines exist / lets make everything green again
Status: Active » Needs work

Made a start on getting everything green again

CSpell - Most words looked project specific, the only ones that I wasn't sure on are there are a few UI labels using British spelling (e.g. Neighbourhood instead of Neighborhood) - it looks from a quick scan that this was withing the context of screens where the US spelling is presented (e.g Organization instead of Organisation) so I assume these are genuine misspellings. Not fixed given they impact UI - wanted clarification first.

CSpell - organisation looks like it was used in the migration plugin - so its in the dictionary but perhaps should be just ignored in the plugin?

PHPCS - minor fixes *edit* - it looks my changes here were just duplicating the work already done in #3492425: Nullable types must be explicit

PHPStan - updated the baseline to ignore some deprecations related to things introduced in 10.3. Since 10.2 went out of security support this week, maybe we should just fix these now and have min 10.3 support? Will take maitainers direction here.

PHUnit - version 10 needs dataprovider related methods to be static - made these changes.

There are still 19 failures - 18 will be resolved by #3467623: Drupal 11 compatibility fix for removed views default_argument_skip_url setting

The final one is:

18) Drupal\Tests\address\Unit\Plugin\Validation\Constraint\CountryConstraintValidatorTest::testValidate with data set #3 ('InvalidValue', 'The country %value is not valid.')
Prophecy\Exception\Prophecy\MethodProphecyException: The method "addViolation" has a void return type, and so cannot return anything
/builds/issue/address-3495167/vendor/phpspec/prophecy/src/Prophecy/Prophecy/MethodProphecy.php:256
/builds/issue/address-3495167/tests/src/Unit/Plugin/Validation/Constraint/CountryConstraintValidatorTest.php:60
/builds/issue/address-3495167/vendor/bin/phpunit:122

I have to divert my attention to something else now but its a start.

Setting to needs work for the above - but I think adding a scheduled pipeline is not blocked as if that is done now it will make it more visible that this is the current state. Cheers

ericgsmith’s picture

ericgsmith commented
Title: [Gitlab] Tests fail with PHPUnit 10 after verbose removed / scheduled pipelines exist / lets make everything green again » [Gitlab] Tests fail with PHPUnit 10 after verbose removed / no scheduled pipelines exist / lets make everything green again
bojanz’s picture

bojanz commented

Thank you for your efforts!

Since 10.2 went out of security support this week, maybe we should just fix these now and have min 10.3 support

That sounds fine, let's do that. Committed #3440036: RendererInterface::renderPlain() is deprecated in Drupal 10.3.0, let's see what remains.

CSpell - Most words looked project specific, the only ones that I wasn't sure on are there are a few UI labels using British spelling (e.g. Neighbourhood instead of Neighborhood) - it looks from a quick scan that this was withing the context of screens where the US spelling is presented (e.g Organization instead of Organisation) so I assume these are genuine misspellings.

Yes, those are genuine misspellings we should fix.

I'll go ahead and merge #3467623: Drupal 11 compatibility fix for removed views default_argument_skip_url setting and #3492425: Nullable types must be explicit now, then you can rebase.

In the mean time, I'll take a look at adding a scheduled pipeline.

  • bojanz committed 2cbe0df5 on 2.x 
    Issue #3495167 by ericgsmith: Remove --verbose flag as this is has been...

  • bojanz committed e7ca13ef on 2.1.x 
    Issue #3495167 by ericgsmith: Remove --verbose flag as this is has been...

  • bojanz committed 0d9fb56b on 2.0.x 
    Issue #3495167 by ericgsmith: Remove --verbose flag as this is has been...
bojanz’s picture

bojanz commented
Title: [Gitlab] Tests fail with PHPUnit 10 after verbose removed / no scheduled pipelines exist / lets make everything green again » Tests fail with PHPUnit 10 after verbose removed
Status: Needs work » Fixed

We now have a scheduled pipeline that runs daily.

I moved the cspell/phpstan changes to #3495973: Fix cspell and phpstan builds and committed them there.

I'll fix the phpunit failure in a followup issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.