Problem/Motivation

Looks like we have dead code floating around in QueryAccessHandlerBase. The only other use of Entity API is the RevisionRouteProvider.

The goal is to see what we can drop and if we can drop the dependency altogether.

Issue fork group-3494780

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

kristiaanvandeneynde created an issue. See original summary.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

Checking #2350939: Implement a generic revision UI for revision counterparts in core.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Active » Needs review

Okay we can drop everything, but our revision UI tests now have 2 failures when we do. Need to investigate that.

kristiaanvandeneynde opened merge request !205

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

So only RevisionUiAccessTest::testUpdateDeleteAccess() fails for non-default revisions when reverting. Will have to look into that.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented

This did bring to my attention that core (and now Group) use the'revert' operation, but node still uses 'revert revision'. So we may need to open an issue to adjust group_support_revisions to account for that.

kristiaanvandeneynde’s picture

kristiaanvandeneynde
Primary language Dutch
Location Antwerp, Belgium
commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.