Problem/Motivation

drupal ci is no more.
Comments should not reference it.

Steps to reproduce

Pull down code and search for drupal ci

Proposed resolution

Review and modify the comments appropriately.

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3493279

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

nicxvan’s picture

nicxvan commented
Related issues: -#3342617: Remove drupalci.yml, -#3251185: Remove drupalci.yml

Credit

jvbrian made their first commit to this issue’s fork.

jvbrian opened merge request !10549

jvbrian closed merge request !10549

jvbrian reopened merge request !10549

yujiman85’s picture

yujiman85 commented
Assigned: Unassigned » yujiman85
Status: Active » Needs review
yujiman85’s picture

yujiman85 commented
Assigned: yujiman85 » Unassigned

I checked this out and all mentions of Drupal CI seem to be gone, I also reran the pipeline to get it to pass. I can't comment on the new wording of the comments since I don't know what it's supposed to become so I'll leave this as Needs Review for now.

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Needs Review Queue Initiative

Searched for Drupal CI and all 4 instances have been replaced and the MR appears to have good replacements for each wording.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Back to NW for the above comment.

xamount made their first commit to this issue’s fork.

xamount’s picture

xamount
Primary language English
commented
Status: Needs work » Needs review
yujiman85’s picture

yujiman85 commented
Status: Needs review » Reviewed & tested by the community

The suggested change was made and committed, looks good.

quietone credited mondrake.

quietone’s picture

quietone commented
Status: Reviewed & tested by the community » Needs work

Thanks for working on this.

Just one more thing, the changes here need to be wrapped at 80 characters to meet the Drupal coding standards, https://www.drupal.org/docs/develop/standards/php/php-coding-standards#line-length.

lavanyatalwar’s picture

lavanyatalwar commented
Assigned: Unassigned » lavanyatalwar

Working on it.

lavanyatalwar’s picture

lavanyatalwar commented
Assigned: lavanyatalwar » Unassigned
Status: Needs work » Needs review

Fixed the 80 char wrapping error
Kindly review :)

smustgrave’s picture

smustgrave commented
Status: Needs review » Reviewed & tested by the community

Feedback addressed.

larowlan closed merge request !10549

  • larowlan committed 975aad7e on 11.x 
    Issue #3493279 by jvbrian, xamount, lavanyatalwar, yujiman85, nicxvan,...
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed

Committed to 11.x - thanks all

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.