Ignore all `type: Drupal\Core\Template\Attribute`s, not only the one named "attributes"

The type is wrong:

 content_attributes:
      type: string
      title: 'Content attributes'
      description: 'Same as attributes, except applied to the main content tag that appears in the template.'

should be

 content_attributes:
      type: Drupal\Core\Template\Attribute
      title: 'Content attributes'
      description: 'Same as attributes, except applied to the main content tag that appears in the template.'

If you do that, it'll be ignored automatically :) 👍

Interested in knowing why/how? → See this bit in \Drupal\experience_builder\PropShape\PropShape::getComponentPropsForMetadata():

      // TRICKY: `attributes` is a special case — it is kind of a reserved
      // prop.
      // @see \Drupal\sdc\Twig\TwigExtension::mergeAdditionalRenderContext()
      // @see https://www.drupal.org/project/drupal/issues/3352063#comment-15277820
      if ($prop_name === 'attributes') {
        assert($prop_schema['type'][0] === Attribute::class);
        continue;
      }

Ah, lol, I misread my own code 🙈

      if ($prop_name === 'attributes') {

→ what I wrote is not true. It should just check the type?

MR with test coverage up. 👍

But … does this even work? Doesn't \Drupal\Core\Template\ComponentsTwigExtension::mergeAdditionalRenderContext() only support a single attributes prop? 😅

So that's definitely an upstream bug in SDC.

Assigning for the feedback you asked and removing tag. Not saying that you are the one who should fix the tests 😁

🏓

Per #3513406-8: ValueError: "Drupal\Core\Template\Attribute" is not a valid backing value for enum, this affects the quite popular https://www.drupal.org/project/radix theme significantly.

Basically this just needs to be generalized:
\Drupal\experience_builder\ComponentMetadataRequirementsChecker::check()

    foreach ($metadata->schema['properties'] as $prop_name => $prop) {
      if ($prop_name === 'attributes') {
        continue;
      }

… which is the direction @penyaskito's in-progress MR already is taking 👍 Let's revive & land it!

Marked #3513406 as a duplicate per #3513406-13: ValueError: "Drupal\Core\Template\Attribute" is not a valid backing value for enum. Crediting the contributors there that helped get clarity there, which allowed marking it as a duplicate 😊

Mentioned today, while we are here let's ensure we have a plan (fix here or follow-up) for Attributes prop marked as required works, even if that doesn't make any sense.

Mentioned today, while we are here let's ensure we have a plan (fix here or follow-up) for Attributes prop marked as required works, even if that doesn't make any sense.

👆 This is not yet addressed, but the MR is ready, so tagging Needs followup.

Also linking the core issues that @penyaskito found in his research at https://git.drupalcode.org/project/experience_builder/-/merge_requests/1...

LGTM — only needs addressing of @larowlan's edge case, and just have 2 minor questions.

Handled feedback. Created follow-up`#3537610: Handle required `type: Drupal\Core\Template\Attribute`s props in SDCs

Thanks!

Thanks!