Problem/Motivation
This is a good first time issue for new users
The pipeline lists a number of phpstan errors that need to be address
Steps to reproduce
N/A
Proposed resolution
Address all
Remaining tasks
Do it
Implement
Pipeline works
User interface changes
N/A
API changes
N/A
Data model changes
N/A
Issue fork quicktabs-3492949
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
immaculatexavier commentedComment #3
smustgrave commentedFYI I tagged for novice for new users to try first
Comment #4
smustgrave commentedSo please reserve for them. Ticket isn’t 24hours old yet
Comment #5
rahul_ commentedI can take this, and start work on it.
Comment #7
anish.a commentedFYI, these are the errors
Comment #8
lavanyatalwar commentedWorking on it.
Comment #9
anish.a commented@lavanyatalwar It is already being worked on by @rahul_ in DrupalCon Singapore and he is already in finishing stages. I suggest to take up another issue to avoid duplicate work.
Comment #10
rahul_ commentedI am still working on this, will continue for another 24 hours.
Till Now -
I fixed most of the Errors mentioned above, and only a few are remaining, once I fix them tomorrow, and test the module, I will mark PR as ready for review.
ddev . phpstan analyze web/modules/contrib/quicktabsComment #11
smustgrave commentedComment #12
smustgrave commentedFollowing up on this, would like to include in the release.
Comment #13
rahul_ commentedStill working on this.
Comment #14
anish.a commented@rahul_ Can you push the WIP in the branch, so that I can take a look.
Comment #15
rahul_ commented@anish.a you can continue from scratch, because due to some mistake, all my code is reverted :(.
Comment #16
anish.a commentedI am taking this up. I will push the changes on what I had done by today itself.
Comment #18
anish.a commentedCreated a draft MR. I still need to fix the dependency injection errors, continuing the work.
Comment #19
anish.a commentedChanging the status and assigning to me as I am continuing working on this.
Comment #20
anish.a commentedI had submitted a rough draft and I need some help on finishing it.
Comment #22
smustgrave commentedThanks all