Problem/Motivation

PHP 8.4 has deprecated implicit nullable types.

Steps to reproduce

Use in a PHP 8.4 environment

Proposed resolution

Use explicit nullable types (compatible with PHP 7.1+ so no compatibility concerns given Drupal core PHP minimums)

Does change function signatures so may be best to have a new major version

CommentFileSizeAuthor
#5 3492432-ctools-5.patch621 byteskiseleva.t

Issue fork ctools-3492432

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nickdickinsonwilde created an issue. See original summary.

nickdickinsonwilde opened merge request !74

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Active » Needs review
Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

The nullable type was made exclusive
Moving to RTBC+

kiseleva.t’s picture

kiseleva.t commented
StatusFileSize
new 3492432-ctools-5.patch621 bytes

Exported MR into patch to use in composer.

hosterholz’s picture

hosterholz
he/him
Primary language German
commented

MR !74 works.
RTBC+1

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Status: Reviewed & tested by the community » Fixed

Thanks @nickdickinsonwilde and others for taking a look. I have merged this into the dev branch.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

rajab natshah’s picture

rajab natshah
he/him
commented

Thanks for the fix
Hoping for a release.

rajab natshah’s picture

rajab natshah
he/him
commented
Priority: Normal » Major
rajab natshah’s picture

rajab natshah
he/him
commented

Hopping for a tag release.
Thank you :)