Problem/Motivation

PHP 8.4 has deprecated implicit nullable types.

Steps to reproduce

Use in a PHP 8.4 environment

Proposed resolution

Use explicit nullable types (compatible with PHP 7.1+ so no compatibility concerns given Drupal core PHP minimums)

Issue fork tmgmt-3492379

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nickdickinsonwilde created an issue. See original summary.

nickdickinsonwilde opened merge request !85

nickdickinsonwilde’s picture

nickdickinsonwilde
He/Him/His
Primary language English
Location Victoria, BC (T'So-uke lands)
commented
Status: Active » Needs review

ready for review

Anonymous’s picture

Anonymous (not verified) commented
Status: Needs review » Reviewed & tested by the community

I reviewed the MR
The changes look good
Explicit nullable types were used as suggested
Moving to RTBC+

phily’s picture

phily
he/him
Primary language French
Location 🇪🇺🇫🇷 Paris, France
commented

MR!85 works for me using PHP 8.4.14, Drupal 11.3.1 and TMGMT 8.x-1.17

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Tests are currently failing, but that's not the fault of this issue. Merged.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.