Problem/Motivation

Let's add dependency injection to Comment Hooks.

Steps to reproduce

Review the files

Proposed resolution

Add dependency injection for services in the hooks.

Remaining tasks

User interface changes

N/A

Introduced terminology

N/A

API changes

N/A

Data model changes

N/A

Release notes snippet

N/A

Issue fork drupal-3492284

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

nicxvan created an issue. See original summary.

aloyr’s picture

aloyr commented

I'm working on this

larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Issue tags: +Singapore2024
longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Title: Add Dependency Injection » Add dependency injection to comment.module hooks
Component: base system » comment.module
nicxvan’s picture

nicxvan commented

Thanks, that title and component are much better.

I'm using this issue to help Aloyr learn the ropes of contribution using Gitlab

nicxvan opened merge request !10986

mcgovernm made their first commit to this issue’s fork.

nicxvan’s picture

nicxvan commented
Title: Add dependency injection to comment.module hooks » [pp-1] Add dependency injection to comment.module hooks
Status: Active » Postponed

@mcgovernm thanks for working on that conflict, if I'm being honest rebasing for stan is a bit premature on this issue, there are a lot of other organizational changes that need to happen before we really check the pipeline.

I've been slowly working through some thoughts and contribution processes with @aloyr offline too. This should technically be postponed on #3493453: [meta] Standardize and clean up hook classes in core I'm using this as a real world example to test some principles there.

If you'd like to contribute to this effort feel free to create an issue like this for another core module and I'd be happy to assist over there as well.

Version: 11.x-dev » main

Drupal core is now using the main branch as the primary development branch. New developments and disruptive changes should now be targeted to the main branch.

Read more in the announcement.