Problem/Motivation

Steps to reproduce

 ------ ---------------------------------------------------- 
  Line   src/ChartManager.php                                
 ------ ---------------------------------------------------- 
  28     Missing cache backend declaration for performance.  
 ------ ---------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Form/ChartsConfigForm.php                                         
 ------ ---------------------------------------------------------------------- 
  73     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  74     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
  75     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 ------ ---------------------------------------------------------------------- 
  Line   src/Plugin/chart/Library/ChartBase.php                                
 ------ ---------------------------------------------------------------------- 
  31     \Drupal calls should be avoided in classes, use dependency injection  
         instead                                                               
 ------ ---------------------------------------------------------------------- 
 [ERROR] Found 5 errors

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork charts-3491360

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

bluegeek9 created an issue. See original summary.

bluegeek9’s picture

bluegeek9 commented
Assigned: Unassigned » bluegeek9

bluegeek9 opened merge request !118

nikathone’s picture

nikathone
Primary language Swahili
Location Ontario
commented
Status: Active » Needs work

I would say let focus on the reported error like Missing cache backend declaration for performance. and \Drupal calls should be avoided in classes, use dependency injection instead if they are not breaking backward compatibility.

bluegeek9 opened merge request !123

bluegeek9’s picture

bluegeek9 commented
Assigned: bluegeek9 » Unassigned
Status: Needs work » Needs review

I made a MR for just the cache issue.

andileco made their first commit to this issue’s fork.

  • andileco committed c0e3aebc on 5.1.x authored by bluegeek9 
    Issue #3491360 by bluegeek9, nikathone: Issues Reported by PHPstan
andileco’s picture

andileco commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.