Problem/Motivation

Steps to reproduce

Proposed resolution

Add comments for views filter plugins.

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3491289

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

quietone created an issue. See original summary.

quietone opened merge request !10439

Anonymous’s picture

Anonymous (not verified) commented

Comments were added for views filter plugins.
They explain what each method is doing and inheritdoc has been added wherever required.
Lint pipeline is passing
PHPUnit Functional and build pipelines are failing
Will re-run the pipeline to check if they are just random test failures

Anonymous’s picture

Anonymous (not verified) commented
Status: Active » Reviewed & tested by the community

All the tests passed with no errors/warnings, and the pipeline is all green now
Seems like they were just random test failures
The comments added in the MR for Views Filter Plugins seem correct
Thus moving it to RTBC

  • larowlan committed c55ad549 on 11.x 
    Issue #3491289 by quietone: Fix Drupal.Commenting.FunctionComment....
larowlan’s picture

larowlan
Location 🇦🇺🏝.au GMT+10
commented
Status: Reviewed & tested by the community » Fixed 
----------------------------------------------------------------------------------------------------

Running PHPStan on changed files.
 ------ ------------------------------------------------------------------------------------ 
  Line   modules/filter/src/Plugin/Filter/FilterHtml.php                                     
 ------ ------------------------------------------------------------------------------------ 
  270    Method                                                                              
         class@anonymous/modules/filter/src/Plugin/Filter/FilterHtml.php:265::setTextMode()  
         has no return type specified.                                                       
 ------ ------------------------------------------------------------------------------------ 


                                                                                
 [ERROR] Found 1 error                                                          
                                                                                


PHPStan: failed

This failed on commit check - but that's a filter plugin, not a views filter plugin so is out of scope, reverted that changed and it passed

Committed to 11.x - thanks!
More phpcs rules - nice!

larowlan closed merge request !10439

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.