Problem/Motivation

The class \Drupal\private_message\Form\PrivateMessageDeleteForm is marked as internal.
Overriding a form is such a common practice... and in this case there is not a good reason that I can foresee why this is the only class in the module that is marked as internal.

When I try to extend it, I have an error in phpstan validation:
Class Drupal\mymodule\Form\PrivateMessageDeleteForm extends @internal class Drupal\private_message\Form\PrivateMessageDeleteForm.

Proposed resolution

Remove the internal tag.

Issue fork private_message-3491271

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

dxvargas created an issue. See original summary.

dxvargas opened merge request !164

dxvargas’s picture

dxvargas commented
Assigned: dxvargas » Unassigned
Status: Active » Needs review

I've created a MR to remove the tag, please review.

chandansha’s picture

chandansha commented
Status: Needs review » Reviewed & tested by the community

I have tested MR164. Now Tag is removed and also phpstan pipeline is successfully pass.
I move it to RTBC.
THANKS!!

claudiu.cristea made their first commit to this issue’s fork.

  • claudiu.cristea committed 17a48a67 on 3.0.x 
    Issue #3491271 by dxvargas, chandansha: Remove the tag @internal from...
claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Status: Reviewed & tested by the community » Fixed

Thank you for contribution.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

claudiu.cristea’s picture

claudiu.cristea
Primary language Romanian
Location Arad 🇷🇴
commented
Version: 4.x-dev » 3.0.x-dev