Upgrading from wxt 5.2.3 to wxt 5.3.0
During the first update.php / drush updb there's an error that occurs when wxt.versions and wxt_core.versions are processed. The error occurs during the system_post_update_add_langcode_to_all_translatable_config process.
I've found a workaround to get past this which is to run two drush cdel commands as follows:
drush cdel wxt.versions -y;
drush cdel wxt_core.versions -y;
@smulvih2, do you have any idea what might be going on here? Are these two configs still required or are they optional?
admin_toolbar_links_access_filter was deprecated upstream, previously required by wxt_admin
admin_toolbar_links_access_filter now has been force uninstalled by an update in the admin_toolbar module. It was part of the admin_toolbar module.
This caused wxt_admin to be uninstalled and this explains why we had to delete those wxt.versions / wxt_core.versions files during our upgrade.
Upgrade from wxt 5.2.3 to wxt 5.3.0
update to wxt_admin.info.yml as seen in the related patch/commit.
TBD
TBD
TBD
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | 3490685-06.patch | 456 bytes | joseph.olstad |
Comments
Comment #2
smulvih2@joseph this is strange, I didn't run into this issue when updating my sites. Those two config files are managed by WxT, when you install/uninstall a module it adds it to these files, like it has since D9. I have a few other sites to update to 5.3.0, so will keep an eye out for this issue.
Comment #3
joseph.olstadHmm, during the upgrade wxt_admin was uninstalled from 5.2.3 to 5.3.0 after running updb. Not sure if this is a problem for us but one issue is I had to delete the wxt.versions and wxt_core.versions configuration using either drush cdel or php code in a hook_update.
I'll have a look at the wxt_admin module code and see what this might mean to us.
Comment #4
joseph.olstadThis might be caused by admin_toolbar_links_access_filter being deprecated.
They're force uninstalling admin_toolbar_links_access_filter now. It was part of the admin_toolbar module.
So I'm guessing that the admin_toolbar hook update that now forces uninstall of admin_toolbar_links_access_filter caused wxt_admin to be uninstalled and this explains why we had to delete those wxt.versions / wxt_core.versions files during our upgrade.
Comment #5
joseph.olstadHere's the commit that is related:
https://git.drupalcode.org/project/admin_toolbar/-/commit/b848f6fcfc9f3b...
Comment #6
joseph.olstadNew patch
https://git.drupalcode.org/project/admin_toolbar/-/commit/b848f6fcfc9f3b...
admin_toolbar_links_access_filter is deprecated for Drupal 10.3+
Please see the related commit in the admin_toolbar module
Comment #7
joseph.olstadWith that said, wxt_admin doesn't seem to do much, I don't believe there's much there to worry about if we lose it in my clients build
With that said, for new installs, this module brings in other modules, appears that the patch I propose will likely resolve some conflict.
Comment #8
joseph.olstadThis patch is good, needs review for patch 6, needs review because there's another similar issue in the queue but they seem to have a larger scope.
Comment #9
joseph.olstadThis patch should do the trick
https://www.drupal.org/files/issues/2024-12-02/3490685-06.patch
Comment #10
joseph.olstadrecommend applying patch 6 to the build.
Comment #11
smulvih2@joseph good call on including this fix! It has been merged with 5.3.x, automated tests are passing, let me know if this helps your upgrade. Thanks!
Comment #12
joseph.olstadThanks, I'm seeing it in the latest wxt-5.3.x dev
got the fix by upgrading wxt.
Comment #13
joseph.olstadComment #14
joseph.olstadComment #15
joseph.olstadComment #16
joseph.olstadFixed in 5.3.x dev
Comment #18
joseph.olstad@smulvih2 for some reason in Slack you reported a related error in WxT 6.1.
The admin_toolbar_links_access_filter module needs to be uninstalled prior to upgrading to wxt 6.1 and it should not be found in wxt 6.x.
Comment #19
smulvih2@joseph
admin_toolbar.installhas theadmin_toolbar_update_8003()hook which uninstalls theadmin_toolbar_links_access_filtermodule, and this is available in WxT 5.4.x. Putting this issue back to Fixed since this is not an issue with WxT 6.1.x.Comment #20
joseph.olstadThis solution was already merged
https://github.com/drupalwxt/wxt/blob/5.4.x/modules/custom/wxt_admin/wxt...