Problem/Motivation

When using a template for a specific external entity type, field groups won't be rendered. The patch introduced in Support for external entities only fixed this for templates without a theme suggestion.

Steps to reproduce

  1. Configure an external entity type my_object
  2. Add a field group to its full view mode
  3. When displaying a my_object using the generic external-entity template, the field group is rendered.
  4. When displaying a my_object using a template with a theme suggestion external-entity--my-object--full, the field group is not rendered.

Proposed resolution

When injecting field_group_build_entity_groups in all entity theming functions, also look for external_entity as a base hook.

Remaining tasks

Review needed.

Issue fork field_group-3489832

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

rob_pr created an issue. See original summary.

rob_pr opened merge request !83

rob_pr’s picture

rob_pr commented
Issue summary: View changes
Status: Active » Needs review
fmb’s picture

fmb commented
Status: Needs review » Reviewed & tested by the community

This patch looks good to me, and I could check it fixes the issue.

liam morland made their first commit to this issue’s fork.

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Version: 8.x-3.x-dev » 4.x-dev

4.x is the active branch and should be used as target branch. Why was it changed?

anybody’s picture

anybody
Primary language German
Location Porta Westfalica
commented
Status: Reviewed & tested by the community » Fixed

Merged into 4.x-dev

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.