AddToCartEvent WSOD for order items with no price [#3489811]

Problem/Motivation

When handling an $order_item for which the price hasn't been calculated yet, AddToCartEvent gives a fatal error:

The website encountered an unexpected error. Please try again later.
Error: Call to a member function subtract() on null in Drupal\google_tag\Plugin\GoogleTag\Event\Commerce\AddToCartEvent->getData() (line 44 of modules/contrib/google_tag/src/Plugin/GoogleTag/Event/Commerce/AddToCartEvent.php).

Steps to reproduce

Execute something like \Drupal::service('commerce_cart.cart_manager')->addOrderItem($cart, $order_item); with:

$order_item = OrderItem::create([
  'type' => 'default',
  'purchased_entity' => $variation->id(),
  'quantity' => 1,
]);

Comment	File	Size	Author
#7	google_tag-3489811-MR101--7.patch	4.04 KB	anybody

Issue fork google_tag-3489811

Show commands

Start within a Git clone of the project using the version control instructions.

Add & fetch this issue fork’s repository

Or, if you do not have SSH keys set up on git.drupalcode.org:

Add & fetch this issue fork’s repository

3489811-addtocartevent-wsod-for changes, plain diff MR !101
Check out this branch for the first time

Check out existing branch, if you already have it locally

About issue forks

Comments

Comment #1

26 November 2024 at 08:04

ts.ag created an issue. See original summary.

Comment #2

19 December 2024 at 13:45

anybody made their first commit to this issue’s fork.

Comment #3

anybody

German

Porta Westfalica

commented 19 December 2024 at 13:49

Priority:

Normal

» Major

This is the related code:

public function getData(): array {
    // @todo leverage config for token replacement.
    $order_item = $this->getContextValue('item');
    assert($order_item instanceof OrderItemInterface);
    $unit_price = $order_item->getUnitPrice();
    assert($unit_price !== NULL);
    $adjusted_price = $order_item->getAdjustedUnitPrice();
    assert($adjusted_price !== NULL);

    $item_data = [
      'item_name' => $order_item->label(),
      'affiliation' => $order_item->getOrder()->getStore()->label(),
      'discount' => $unit_price->subtract($adjusted_price)->getNumber(),
      'price' => $this->formatPriceNumber($unit_price),
      'quantity' => (int) $order_item->getQuantity(),
    ];

assert($unit_price !== NULL); safes us in dev, but not in prod, I guess?

We maybe this needs more defensive checking also for production?
This is major for Drupal Commerce projects.