Problem/Motivation

Some of the improvements in the Drupal 11 rewrite ( #3435726: Drupal 11 compatibility fixes for wordpress_migrate ) (nov 25 version) can be brought forward into the next tagged release alpha7 - they are not dependent on Drupal 11 but are compatible with Drupal 9.

Namely SourceSelectForm.php adding TypedDataManager (link) , the accesscheck in ReviewForm (link), entityfieldmanager on ImageSelectForm (link).

This would not bring in the more sophisticated new factory, interface, config, and changes to static vs object methods, which are included in the D11 patch. This will make it more manageable, and give us a little better next tagged release.

Everyone who worked on the other thread will be credited for this as well.

Proposed resolution

Generate MR with only these elements, then move ahead to tagged release

Remaining tasks

User interface changes

None.

API changes

Adds a now mandatory "access check false" to the entity checks.

Data model changes

None besides using dependency injection instead of \Drupal services.

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

hongpong created an issue. See original summary.

hongpong credited baltowen.

hongpong credited msielski.

hongpong credited ressa.

hongpong’s picture

Status: Active » Reviewed & tested by the community

  • hongpong committed 04f1bce2 on 8.x-3.x
    Issue #3489725 by tolstoydotcom, baltowen, msielski, ressa, HongPong:...
    
hongpong’s picture

Status: Reviewed & tested by the community » Fixed

Something in the IDE flagged the attempt to add TypedDataManager dependency injection so I held that back. Now going to update other MRs. Thanks everyone!!

hongpong’s picture

Category: Task » Feature request

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.