Problem/Motivation

\Drupal\Core\Recipe\InputCollectorInterface is a crucial part of the recipe system's ability to collect user input, and #3483435: Add a trait for forms that want to collect input on behalf of a recipe adds two new implementations of it. That makes it pretty sad that it's totally devoid of documentation.

Proposed resolution

Document this interface and its methods.

CommentFileSizeAuthor
#6 3489026-nr-bot_q7mc_gm1.txt1.12 KBneeds-review-queue-bot

Issue fork drupal-3489026

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phenaproxima created an issue. See original summary.

ajinkya45 made their first commit to this issue’s fork.

ajinkya45 opened merge request !13062

ajinkya45’s picture

ajinkya45 commented
Status: Active » Needs review
phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community

Made one minor change but otherwise I think this is great.

needs-review-queue-bot’s picture

needs-review-queue-bot commented
Status: Reviewed & tested by the community » Needs work
StatusFileSize
new 3489026-nr-bot_q7mc_gm1.txt1.12 KB

The Needs Review Queue Bot tested this issue. It fails the Drupal core commit checks. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

ajinkya45’s picture

ajinkya45 commented
Status: Needs work » Needs review

Pipeline fixed, ready to change status back to RTBC

phenaproxima’s picture

phenaproxima
he/him
Primary language English
Location Massachusetts
commented
Status: Needs review » Reviewed & tested by the community
thejimbirch’s picture

thejimbirch commented

Great work @ajinkya45! +1 for RTBC

quietone made their first commit to this issue’s fork.

quietone’s picture

quietone commented

I rebased and wrapped the new comments to 80 columns. Leaving at RTBC.

quietone’s picture

quietone commented
Version: 11.x-dev » 11.2.x-dev
Status: Reviewed & tested by the community » Fixed

Committed to 11.x. Also to 11.2.x because, as stated in the issue summary, this "is a crucial part of the recipe system's ability to collect user input".

Now that this issue is closed, please review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, please credit people who helped resolve this issue.

  • quietone committed a995c841 on 11.2.x 
    Issue #3489026 by phenaproxima, ajinkya45: Document...

  • quietone committed c780e6b8 on 11.x 
    Issue #3489026 by phenaproxima, ajinkya45: Document...

quietone closed merge request !13062

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.