Problem/Motivation
The version bump for cspell from 8.13.0 => 8.16.0 isn't that big, but since it will end up with a changed dictionary.txt, I'm creating a child issue for it, which is this very issue.
Also: Most likely every backport needs a new round of $ yarn spellcheck:make-dict for the specific branch, which makes giving this update its own issue probably a good approach.
Steps to reproduce
Proposed resolution
$ yarn upgrade-interactive
cspell -------------------------------------- ◯ ^8.13.0 ------ ◉ ^8.16.0 ------
$ yarn spellcheck:make-dict
Remaining tasks
Backport this to the gazillion current branches, TBD by the core committers.
Mote: Most likely every backport needs a new round of $ yarn spellcheck:make-dict for the specific branch.
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3487908
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
Comments
Comment #2
spokjeComment #4
spokjeComment #5
spokjeMirroring status of parent issue, which became critical.
Comment #11
smustgrave commentedI applied the MR for 11.x and the cspell commands appear to work as expected. Assuming the word changes are either the file out of sync or maybe cspell updated their internal dictionaries?
Comment #12
spokjeThe latter for sure, that's the main part of each new minor bump in
cspell.The first part: No clue, maybe, maybe not.
Comment #13
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #14
spokjeWhy don't you help yourself to a nice cold glass of ST[Bleep!]U, needs-review-queue-bot?
Comment #15
smustgrave commentedHey the bot helps me keep the queue low hahaha
But I do think it got confused by the multiple MRs on this one.
Comment #16
spokjeCombo of multiple MRs and it isn't too clever when it comes to *.lock files IMHO, both composer.lock and yarn.lock.
Anyway, this issue was bumped and you noticed it because of the bot, so that's good enough for me :)
Comment #19
longwaveCommitted and pushed to 11.x and 11.1.x, thanks!
10.5.x and 10.4.x don't apply, looks like a merge conflict with another JS dependency update, moving to NW for that.
Comment #23
quietone commentedRebased the 10.4 MR and started over for the 10.5 one. No reason for that, it is just how I did it between other things at home.
Comment #24
spokjeUnsure if I, as the creator of the original branches can RTBC, but since there's not much time left before 10.4.0-RC is shipped, I'm willing to bend the rules and RTBC-ed.
#yolo
Thanks @quietone.
Comment #27
longwaveCommitted and pushed to 10.5.x and 10.4.x, thanks!