Problem/Motivation

The version bump for cspell from 8.13.0 => 8.16.0 isn't that big, but since it will end up with a changed dictionary.txt, I'm creating a child issue for it, which is this very issue.

Also: Most likely every backport needs a new round of $ yarn spellcheck:make-dict for the specific branch, which makes giving this update its own issue probably a good approach.

Steps to reproduce

Proposed resolution

$ yarn upgrade-interactive
cspell -------------------------------------- ◯ ^8.13.0 ------ ◉ ^8.16.0 ------
$ yarn spellcheck:make-dict

Remaining tasks

Backport this to the gazillion current branches, TBD by the core committers.
Mote: Most likely every backport needs a new round of $ yarn spellcheck:make-dict for the specific branch.

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

CommentFileSizeAuthor
#13 3487908-nr-bot.txt91 bytesneeds-review-queue-bot

Issue fork drupal-3487908

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

spokje created an issue. See original summary.

spokje’s picture

Issue summary: View changes

spokje’s picture

Status: Active » Needs review
spokje’s picture

Priority: Normal » Critical
Issue summary: View changes

Mirroring status of parent issue, which became critical.

spokje changed the visibility of the branch 11.x to hidden.

spokje changed the visibility of the branch 3487908- to hidden.

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

I applied the MR for 11.x and the cspell commands appear to work as expected. Assuming the word changes are either the file out of sync or maybe cspell updated their internal dictionaries?

spokje’s picture

Assuming the word changes are either the file out of sync or maybe cspell updated their internal dictionaries?

The latter for sure, that's the main part of each new minor bump in cspell.

The first part: No clue, maybe, maybe not.

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new91 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

spokje’s picture

Status: Needs work » Needs review
Issue tags: +no-needs-review-bot

Why don't you help yourself to a nice cold glass of ST[Bleep!]U, needs-review-queue-bot?

smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Hey the bot helps me keep the queue low hahaha

But I do think it got confused by the multiple MRs on this one.

spokje’s picture

Combo of multiple MRs and it isn't too clever when it comes to *.lock files IMHO, both composer.lock and yarn.lock.

Anyway, this issue was bumped and you noticed it because of the bot, so that's good enough for me :)

  • longwave committed d2cfad9c on 11.1.x
    Issue #3487908 by spokje, smustgrave: Update cspell to latest
    

  • longwave committed 04478f36 on 11.x
    Issue #3487908 by spokje, smustgrave: Update cspell to latest
    
longwave’s picture

Version: 11.x-dev » 10.5.x-dev
Status: Reviewed & tested by the community » Needs work

Committed and pushed to 11.x and 11.1.x, thanks!

10.5.x and 10.4.x don't apply, looks like a merge conflict with another JS dependency update, moving to NW for that.

quietone made their first commit to this issue’s fork.

quietone’s picture

Status: Needs work » Needs review

Rebased the 10.4 MR and started over for the 10.5 one. No reason for that, it is just how I did it between other things at home.

spokje’s picture

Status: Needs review » Reviewed & tested by the community

Unsure if I, as the creator of the original branches can RTBC, but since there's not much time left before 10.4.0-RC is shipped, I'm willing to bend the rules and RTBC-ed.
#yolo

Thanks @quietone.

  • longwave committed bb51f1da on 10.4.x
    Issue #3487908 by spokje, quietone, smustgrave: Update cspell to latest
    

  • longwave committed 9271d92b on 10.5.x
    Issue #3487908 by spokje, quietone, smustgrave: Update cspell to latest
    
longwave’s picture

Version: 10.5.x-dev » 10.4.x-dev
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 10.5.x and 10.4.x, thanks!

nod_ made their first commit to this issue’s fork.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.