Problem/Motivation

https://git.drupalcode.org/project/radix/-/blob/6.0.x/includes/page.them...

What seems like a good idea at first sight, seems to be rather useless / error-prone on multilingual pages.

Steps to reproduce

Proposed resolution

IMO only the Entity-ID is a reliable override suggestion, maybe the default language path is another option, but the path could change at any time, so not very reliable.

Remaining tasks

User interface changes

API changes

Data model changes

Comments

thomas.frobieter created an issue. See original summary.

  • danchadwick committed 2c391744 on 6.0.x 
    Issue #3487702 by danchadwick: Page Twig suggestions based on path_alias...
danchadwick’s picture

danchadwick commented
Status: Active » Postponed (maintainer needs more info)

I agree. It seems like you could do this in a subtheme needed.

@doxigo: your thoughts?

Also, I cleaned up some leftover cruft (getting the node revision, but then not using the result).

doxigo’s picture

doxigo commented

Hey guys,

Dan as I mentioned in the email:

I believe this could be a breaking change and break every website that there is if it’s in the core Radix. That aside the I can’t recall on top of my head about the error that this causes in multilingual pages, and the issue but I know that I’ve used the path alias based suggestions quite a lot.

If it were up to me, I’d try to fix it rather removing it, but feel free to make your own decision.

danchadwick’s picture

danchadwick commented
Status: Postponed (maintainer needs more info) » Closed (works as designed)

This think the concern is/was that a translated path alias would be quite brittle. However, given that this has been in radix since v5, let's leave it alone to avoid a breaking change.

@thomas.frobieter: Thanks for your suggestion. If we didn't have existing users, I'd would have removed the suggestion for path alias.