Problem/Motivation
Yes, there's no alpha release yet!
Yes, it's probably too early for this!
Yes, it's an ever moving target!
I'm going to do it anyway, even if it isn't committed right away.
If we hit any major issue, this way, we have time to actually think/discuss and fix them and not be pressure-hurried by a release date.
</End of smugness>
We should release 10.4.0-beta1 on the latest dependencies.
Steps to reproduce
$ composer outdated
Proposed resolution
$ composer update
Remaining tasks
- Decide if we need to document the new dev-dependencies introduced by the update of open-telemetry/sdk
Confirmed by multiple core committers: No we don't.
- Decide if we want to make the major jump to 2.x for PHPStan in the 10.x branch
User interface changes
Introduced terminology
API changes
Data model changes
Release notes snippet
| Comment | File | Size | Author |
|---|
Issue fork drupal-3486545
Show commands
Start within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
- 3486545-10.5.x-update-composer-dependencies
changes, plain diff MR !10121
Comments
Comment #2
spokjeComment #4
spokjeComment #5
spokjeSo
1) There are some new dev-dependencies, which is why 2 additions to the
cspelldictionary are present.2) One of these new dev-dependencies,
tbachert/spi, needs permission to be inallow-plugins.3) We bumped
mglaman/phpstan-drupal, which made 4 suppression disappear in the baseline. (See https://github.com/mglaman/phpstan-drupal/issues/780)Because this baseline won't pass with any version lower than
1.2.12, I bumped to this version as the minimum incomposer.jsonComment #6
spokjeRegarding 2) from the previous comment, there are already issues open about that: #3478895: Document new Composer plugin tbachert/spi required by core-dev and #3484463: Upgrade open-telemetry packages for PHP 8.4.
Comment #7
spokjeBesides
tbachert/spi, I see four more new dev-dependencies:1)
brick/math:2)
nyholm/psr7-server:3)
ramsey/collection:4)
ramsey/uuidSo every one of the five new dev-dependencies come from
open-telemetry/sdk.Do we need to document this/all of the dependencies individually/ignore this completely?
EDIT: Hmmm, looking at https://www.drupal.org/about/core/policies/core-dependency-policies-and-... we:
a) are hopelessly behind on our current documentation.
b) trying to document all 5(?) current branches is going to be a slight nightmare.
c) also seem to have JS dependencies in that page (PostCSS)
d) seem to only document our direct dev-dependencies.
If d) is true, there won't be a need to document the new sub-dependencies IMHO.
Comment #8
spokjeComment #9
spokjeComment #10
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
spokjeBad bot, get out!
Also: Do we want/are allowed to make the major jump to 2.x for PHPStan in the 10.x branch?
Comment #12
spokjeComment #13
spokjeComment #14
spokjeRebased and updated #4
Comment #15
andypostComment #16
andypostRebased after #3484463: Upgrade open-telemetry packages for PHP 8.4 and updated bit more, looks ready to go
Comment #17
spokjeThanks @andypost!
Of course this is an ongoing battle: https://github.com/symfony/symfony/releases/tag/v6.4.15
Updated MR and #4
Comment #18
andypostLet's get it in and unblock PHP 8.4
Comment #19
andypostGuzzle update is the only requirement for PHP 8.4 compatibility
Pushed bit more
Comment #20
andypostreverted twig to 3.14.2 as it breaks a lot of tests
Comment #21
andypostFiled #3488365: Upgrade twig/twig to 3.15.0
Comment #22
andypostAnd one more #3488401: upgrade prophecy to 1.20
Comment #25
catchCommitted/pushed to 10.5.x and 10.4.x, thanks!
Comment #27
quietone commentedThe requirement for documentation for dependencies recently changed. As @spokje points out keeping it up to date is a 'slight nightmare'. The information links for all dependencies do not need to be documented in the 'Current PHP dependencies' or the 'Current Javascript dependencies' pages. Only those are are "large security or API surface" need to be documented. For the rest, we can now use the data provided in the issue, using a new tag 'approved dependency evaluation'. See issues tagged "approved dependency evaluation".
This is explained in Dependency information links.