Problem/Motivation

This module is reported to have issues that make it incompatible for Drupal 11.
Attached is a screenshot from the upgrade_status module reporting on issues
for email_tfa.

Steps to reproduce

Install the upgrade_status module
scan the email_tfa module for issues.

Proposed resolution

I have produced a patch file which seems to work for us - it addresses
both issues reported. See email_tfa.patch

Remaining tasks

User interface changes

API changes

Data model changes

CommentFileSizeAuthor
#5 Screenshot from 2024-11-07 18-49-20.png69.2 KBriddhi.addweb
#4 email_tfa-3485953.patch1.19 KBsarwan_verma
#4 error.png47.11 KBsarwan_verma
#2 Screenshot 2024-11-06 at 11.17.31 AM.png234.85 KBwill_frank
email_tfa.patch2.85 KBwill_frank

Issue fork email_tfa-3485953

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

will_frank created an issue. See original summary.

will_frank’s picture

will_frank commented
StatusFileSize
new Screenshot 2024-11-06 at 11.17.31 AM.png234.85 KB
sarwan_verma’s picture

sarwan_verma commented
Assigned: Unassigned » sarwan_verma
sarwan_verma’s picture

sarwan_verma commented
Assigned: sarwan_verma » Unassigned
Status: Active » Needs review
StatusFileSize
new error.png47.11 KB
new email_tfa-3485953.patch1.19 KB

Hi,

The patch did not apply successfully for me, but I have resolved the "Drupal 11 Compatibility" issues and created a new patch.
Please review and verify.

Thanks!

riddhi.addweb’s picture

riddhi.addweb commented
Status: Needs review » Needs work
StatusFileSize
new Screenshot from 2024-11-07 18-49-20.png69.2 KB

When I tried to apply the patch[email_tfa-3485953.patch], it gives the error, patch did not apply successfully. Attaching SS for the same.

abdulaziz zaid’s picture

abdulaziz zaid
Primary language Arabic
Location Riyadh 🇸🇦
commented
Category: Bug report » Task

It is a Task, not a bug

  • abdulaziz zaid committed 8500e50b on 2.0.x 
    Issue #3485953 by sarwan_verma, will_frank, riddhi.addweb, abdulaziz...
abdulaziz zaid’s picture

abdulaziz zaid
Primary language Arabic
Location Riyadh 🇸🇦
commented
Status: Needs work » Fixed
Issue tags: +email_tfa v2.0.4

Thanks Everyone.

We fixed this on the dev version for now, and I will push a new version soon, 2.0.4

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.