The Twig Placeholders module provides a simple and flexible way to generate placeholder content directly within Twig templates.
It allows developers to insert placeholder lorem ipsum text, images, logos, videos, menu data, form select data, table data and other mock content.
This module is designed for theme developers, frontend engineers, and anyone needing quick, dynamic placeholders in their templates to showcase their single directory components or other framework components in a component library for themselves or their clients.
Project link
https://www.drupal.org/project/twig_placeholders
I have run phpcs --standard=Drupal,DrupalPractice and everything looks good.
The project is currently using GitLab pipelines and passes on all tests.
| Comment | File | Size | Author |
|---|---|---|---|
| #8 | security-advisory-user.png | 7 KB | vishal.kadam |
Comments
Comment #2
d.fisher commentedComment #3
vishal.kadamThank you for applying!
Please read Review process for security advisory coverage: What to expect for more details and Security advisory coverage application checklist to understand what reviewers look for. Tips for ensuring a smooth review gives some hints for a smoother review.
The important notes are the following.
phpcs --standard=Drupal,DrupalPracticeon the project, which alone fixes most of what reviewers would report.To the reviewers
Please read How to review security advisory coverage applications, Application workflow, What to cover in an application review, and Tools to use for reviews.
The important notes are the following.
For new reviewers, I would also suggest to first read In which way the issue queue for coverage applications is different from other project queues.
Comment #4
vishal.kadamUsually, after reviewing a project, we allow the developer to opt projects into security advisory coverage.
This project is too small for us and it doesn't contain enough PHP code to really assess your skills as a developer.
Have you created any other project on drupal.org (module, theme, distribution) we could instead review? The project needs to have most of the commits (preferable all the commits) done by you.
Comment #5
d.fisher commentedCurrently, I don't have any other modules. This is my first. If I create any more I'll update this issue.
Comment #6
d.fisher commentedI have added another maintainer who maintains a great deal more modules than I and has been a backend Drupal developer for 16+ years.
See: https://www.drupal.org/u/barry_fisher
Comment #7
d.fisher commentedAre the security advisory coverage applications per module or per maintainer? If per maintainer how can we tell if a maintainer can opt projects in?
Comment #8
vishal.kadamThe security advisory coverage application process assigns the required role to the applicant, enabling them to opt projects into security advisory coverage.
To verify if a user has the necessary role to opt a module into security advisory coverage, navigate to the user profile and check for the section labeled "Can opt projects into security advisory coverage."
Comment #9
avpadernoAdding as maintainer somebody who is already able to opt projects into security advisory coverage does not speed up this application, which aims to give you the drupal.org role necessary to opt projects you create or for which you can edit the project node into security advisory coverage and make commits.
It does not actually change the fact the project used for this application does not have enough PHP code to be reviewed, which is the reason the status is now Needs work.
Comment #10
d.fisher commentedThank you very much for the clarification. The other maintainer is able to opt projects in to security advisory coverage so is it worth closing this issue and I'll open another one when I have another contrib project with more PHP for you to review?
Comment #11
avpadernoWe can do so, yes.
Comment #12
d.fisher commentedJust popping back and marking this as needs review again.
I've recently created another module which contains more PHP than this one. See: https://www.drupal.org/project/twig_placeholders
I've been following all the standards and hopefully this will give you a better idea of my capabilities. I've been working with Drupal for over 10 years professionally for a variety of enterprise organisations and am now looking to be more involved in the contrib space and being able to opt projects in to security advisory coverage will be a major step. For example I have an application open to maintain / co-maintain an abandoned module: https://www.drupal.org/project/projectownership/issues/3514042 and have recently become a co-maintainer on the nodeaccess project https://www.drupal.org/project/nodeaccess.
In addition to this I've also added additional commits to the twig_casings project and intend to continue updating and supporting these modules for many years to come.
Comment #13
avpadernoComment #14
d.fisher commentedComment #15
avpadernoThank you for your contribution and for your patience with the review process!
I am going to update your account so you can opt into security advisory coverage any project you create, including the projects you already created.
These are some recommended readings to help you with maintainership:
You can find more contributors chatting on Slack or IRC in #drupal-contribute. So, come hang out and stay involved!
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.
Comment #16
avpadernoComment #17
d.fisher commentedThank you so much! I really appreciate your review.
Comment #18
avpaderno