When running PHPUnit tests locally I saw quite a few deprecation warnings which we can easily fix.

Issue fork search_api-3483959

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

drunken monkey created an issue. See original summary.

drunken monkey opened merge request !179

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Active » Needs review

Created an MR.

Would be great to let the CI test for deprecations, but unsure how to do that.
Locally, I just used the .deprecation-ignore.txt from Core but added a line for ignoring all deprecated Search API hooks (since reporting those is pointless).

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Found it!

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented

Hm, completely failing on a deprecation is a bit much, though, I’d have hoped to just get a warning …

drunken monkey’s picture

drunken monkey
he/him
Primary language German
Location Vienna, Austria
commented
Status: Needs review » Fixed

Merged.

  • drunken monkey committed 5e57820a on 8.x-1.x 
    Issue #3483959 by drunken monkey: Fixed some deprecation warnings.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.