Closed (fixed)
Project:
Drupal core
Version:
11.x-dev
Component:
workspaces.module
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
18 Oct 2024 at 15:06 UTC
Updated:
25 Feb 2025 at 12:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
heddnIt might seem strange to make a change to the listing page itself, but now we lowered the bar on access to the listing page, there are operational links that appear that the user is not allowed access to use.
Comment #4
smustgrave commentedSmall request.
Comment #5
heddnComment #6
smustgrave commentedThanks!
Comment #7
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #8
heddnBack to RTBC. It was only a trivial merge conflict.
Comment #9
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #11
shalini_jha commentedFixed the conflict and rebased MR, seems like some random test failure.
Comment #12
shalini_jha commentedRe run the random failed pipeline , now its green . AS i have just re base & resolved conflict. so moving this Back to RTBC.
Comment #13
quietone commentedI read the is, comments and the MR. All questions answered and I have none of my own. I updated credit.
Comment #14
quietone commentedI was also thinking that a change record help would be useful.
Comment #15
heddnCR added
Comment #18
catchI wasn't sure about the URL access checking here compared to something else, but didn't have an idea what the something would be, and @amateescu confirmed there's currently not an alternative.
Committed/pushed to 11.x, thanks!