Problem/Motivation

While working on workspaces_approval module, we have a real need for reviewers of workspace changes to see all workspaces, but not have edit access. But the route entity.workspace.collection requires administer workspaces+edit any workspace. This should simply be view any workspace.

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

Introduced terminology

API changes

Data model changes

Release notes snippet

Issue fork drupal-3481766

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

heddn created an issue. See original summary.

heddn’s picture

Status: Active » Needs review

It might seem strange to make a change to the listing page itself, but now we lowered the bar on access to the listing page, there are operational links that appear that the user is not allowed access to use.

smustgrave’s picture

Status: Needs review » Needs work

Small request.

heddn’s picture

Status: Needs work » Needs review
smustgrave’s picture

Status: Needs review » Reviewed & tested by the community

Thanks!

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

heddn’s picture

Status: Needs work » Reviewed & tested by the community

Back to RTBC. It was only a trivial merge conflict.

needs-review-queue-bot’s picture

Status: Reviewed & tested by the community » Needs work
StatusFileSize
new90 bytes

The Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".

This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.

Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.

shalini_jha made their first commit to this issue’s fork.

shalini_jha’s picture

Fixed the conflict and rebased MR, seems like some random test failure.

shalini_jha’s picture

Status: Needs work » Reviewed & tested by the community

Re run the random failed pipeline , now its green . AS i have just re base & resolved conflict. so moving this Back to RTBC.

quietone’s picture

I read the is, comments and the MR. All questions answered and I have none of my own. I updated credit.

quietone’s picture

I was also thinking that a change record help would be useful.

heddn’s picture

CR added

  • catch committed 528fc775 on 11.x
    Issue #3481766 by heddn, shalini_jha, quietone, smustgrave: Workspaces...

catch credited amateescu.

catch’s picture

Status: Reviewed & tested by the community » Fixed

I wasn't sure about the URL access checking here compared to something else, but didn't have an idea what the something would be, and @amateescu confirmed there's currently not an alternative.

Committed/pushed to 11.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.