There is some inconsistency in the core version: MigrateSkipFieldsByName::skipFieldStorage() uses

$core_version = $this->settings->get('migrate_skip_field_source_version');

but other parts (and documentation as well) use 'migrate_skip_fields_source_version'

CommentFileSizeAuthor
#2 inconsistency-in-configuration-3481643.patch832 bytesananya.k

Issue fork migrate_skip_fields-3481643

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

_gradient_ created an issue. See original summary.

ananya.k’s picture

ananya.k commented
Status: Active » Needs review
StatusFileSize
new inconsistency-in-configuration-3481643.patch832 bytes

Please refer to attached patch.

_gradient_ opened merge request !9

dinarcon’s picture

dinarcon commented
Status: Needs review » Needs work

Thanks for the report and the fix @_gradient_ and @ananya.k

I would say that most upgrades nowadays are from Drupal 7. Let's make this setting optional and provide a default to '7'.

baltowen made their first commit to this issue’s fork.

baltowen’s picture

baltowen commented
Status: Needs work » Needs review

Hi, I added the default value, please review.

  • _gradient_ committed f6023e40 on 1.0.x 
    Issue #3481643: Make skip fields core version consisntant
dinarcon’s picture

dinarcon commented

Tested the changes manually and things works as expected. The migrate_skip_fields_source_version is no longer required and defaults to '7'. Thanks everyone for your contributions. I will tag a new release with this fix.

dinarcon’s picture

dinarcon commented
Status: Needs review » Fixed

Thanks! This has been released as part of version 1.0.0-alpha6

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.