Problem/Motivation

Per the comment in this resolved issue https://www.drupal.org/project/tb_megamenu/issues/3192235#comment-13963908 - aren't the list roles on menu uls supposed to be removed? They still exist, and because their parent list items don't have a role, accessibility tools are marking the mega menu as out of compliance per: https://www.w3.org/WAI/standards-guidelines/act/rules/bc4a75/proposed/

Steps to reproduce

Check markup: role="list" still exists on the ul tags.

Proposed resolution

Remove $vars['attributes']['role'] = 'list'; from subnav, submenu, and nav functions.

CommentFileSizeAuthor
#5 Role_After.png323.48 KBdebrup
#5 Role_Before.png323.47 KBdebrup

Issue fork tb_megamenu-3481553

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

toddwalden created an issue. See original summary.

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: Unassigned » sourabhsisodia_

sourabhsisodia_ opened merge request !94

sourabhsisodia_’s picture

sourabhsisodia_ commented
Assigned: sourabhsisodia_ » Unassigned
Status: Active » Needs review
debrup’s picture

debrup commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Role_Before.png323.47 KB
new Role_After.png323.48 KB

I have reviewed the changes. The fix is working as expected, due to the role attribute being successfully removed from the ul tags.

The test was performed on a Drupal 11.1.1 site.Attached some screenshots of the final markups.

Moving the issue to RTBC.

themodularlab’s picture

themodularlab
He/Him
Primary language English
commented
themodularlab’s picture

themodularlab
He/Him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.