Problem/Motivation

This is an overview ticket to provide good test coverage for Lupus Decoupled Drupal. Currently only API responses are tested in the main module, and they cover menus, metatags and schema metatags, 404 responses, frontend redirects and regular (and api) output links for node.

Other things that would be nice to have test coverage are:

Comments

useernamee created an issue. See original summary.

useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Issue summary: View changes
useernamee’s picture

useernamee commented
Status: Active » Needs review

All 3 subtickets need review:
- #3475738: Add tests for Lupus Decoupled views
- #3481050: Add tests for lupus_decoupled_user_forms
- #3485928: Add README and tests for Lupus Decoupled Block

fago’s picture

fago
Primary language German
Location Vienna
commented
Title: Good test coverage for lupus_decoupled » [META] Good test coverage for lupus_decoupled
Status: Needs review » Active

Let's mark this is as META and only set the issues with acutal code for needs-review.

useernamee’s picture

useernamee commented
Status: Active » Needs review

One issue left to review: #3481050: Add tests for lupus_decoupled_user_forms

fago’s picture

fago
Primary language German
Location Vienna
commented
Assigned: Unassigned » useernamee

I think we are pretty much done here, but there is one issue which confused me: Test location. It seems we have some tests under the main module, while others are split in the moduels we are testing. Where should tests go? I think we shall decide on a rule and then make a child-task to make sure it's enforced. Thoughts on the right rule?

useernamee’s picture

useernamee commented

Generally I'd argue that tests for specific functionality that a module provides should live in that module. We have however broken that pattern at the beginning with the general test and later on with the views integration.

For general tests:
- https://git.drupalcode.org/project/lupus_decoupled/-/blob/1.x/tests/src/...
- https://git.drupalcode.org/project/lupus_decoupled/-/blob/1.x/tests/src/...
I think it is fine if they stay on the top level module, but the views tests should go into the lupus_decoupled_views submodule.

fago’s picture

fago
Primary language German
Location Vienna
commented
Status: Needs review » Fixed

ok, I created the remaining todo then: https://www.drupal.org/project/lupus_decoupled/issues/3526744

So else, this is done!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.