Problem/Motivation

in regcode.module there are 2 typos: registration_codes this should be registration_code. Now there are dep injection erros logged.

Steps to reproduce

consume a registration code via regcode_code_consume, an error is logged and the code is not consumed.

Proposed resolution

will provide patch.

Issue fork regcode-3480858

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

jb044 created an issue. See original summary.

jb044 opened merge request !22

tr made their first commit to this issue’s fork.

tr’s picture

tr commented

I found one more place that had that same problem.

I also wrote some test cases to make sure the replacement of the procedural functions with service methods was done properly. That's something I would normally do but didn't do for this module because there are so few people using the module and because writing the tests is an annoying amount of boilerplate work. But since you found a problem, the tests will ensure that there are no other hidden problems here.

tr’s picture

tr commented
Status: Active » Fixed

As I said, an annoying amount of boilerplate work. But the tests are working now.

tr’s picture

tr commented
Status: Fixed » Needs review

Meant "Needs review"

  • tr committed 830eae47 on 2.0.x authored by jb044 
    Issue #3480858 by tr, jb044: use of incorrect service:...
tr’s picture

tr commented
Status: Needs review » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.