Problem/Motivation

Running the module with Drupal 10.3.6, I get errors when trying to save the text format:

  • 'animation' is not a supported key
  • 'speed' is not a supported key

because of the missing config/schema/text_rotator_filter.schema.yml file

Here's a suggested content for this file:

filter_settings.filter_text_rotator:
  type: filter
  label: 'Text Rotator Filter'
  mapping:
    animation:
      type: string
      label: 'Animation type'
    speed:
      type: integer
      label: 'Animation speed'

Patch attached.

CommentFileSizeAuthor
#4 with-patch.png112.74 KBsarwan_verma
#4 with-out-patch.png106.15 KBsarwan_verma
filter_text_rotator-d10.3_schema_file.patch461 bytesphily

Issue fork text_rotator_filter-3480088

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

phily created an issue. See original summary.

sarwan_verma made their first commit to this issue’s fork.

sarwan_verma opened merge request !2

sarwan_verma’s picture

sarwan_verma commented
Status: Active » Needs review
StatusFileSize
new with-out-patch.png106.15 KB
new with-patch.png112.74 KB

Hi,

The patch was applied successfully and worked for me. I have also created MR!2 and attached a screenshot for clarity.

Please review and verify.

Thanks!

dom.’s picture

dom. commented

Correct !
As a follow-up for D10.3+ I will however move from Annotation to Attributes:
https://www.drupal.org/node/3229001

  • dom. committed e509fcb6 on 2.x authored by sarwan_verma 
    Issue #3480088 by sarwan_verma, phily: Missing text_rotator_filter....
dom.’s picture

dom. commented
Status: Needs review » Fixed

Fixed in release 2.0.2:
https://www.drupal.org/project/text_rotator_filter/releases/2.0.2

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.