Problem/Motivation

Steps to reproduce

Proposed resolution

Remaining tasks

User interface changes

API changes

Data model changes

Issue fork siteimprove-3479319

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

sokru created an issue. See original summary.

sokru opened merge request !25

mohd sahzad made their first commit to this issue’s fork.

sokru’s picture

sokru commented
Status: Active » Needs review

I tried to keep the changes as minimal as possible, Eslint, Stylelint and CSPell issues should be handled on separate issue.

darvanen’s picture

darvanen
he/him
Primary language English
Location Sydney, Australia
commented
Status: Needs review » Needs work

Have made a few comments on the MR, of particular concern is the removal of some of the logical structures.

The most common procedure I have seen on other modules has been to just have this issue turn on CI then create follow-ups for all of the issues arising from the tests. I suggest we do that here too.

rajeshreeputra made their first commit to this issue’s fork.

rajeshreeputra opened merge request !30

rajeshreeputra’s picture

rajeshreeputra
he/him
Location Pune
commented
Status: Needs work » Needs review

To ensure clarity and simplicity, let's add the .gitlab-ci.yml file as part of this issue. Will address and resolve the issue reported by the CI in the associated tickets.

Hence moving ahead and requesting review for MR!30.