By plopesc on
Change record status: 
Published (View all published change records)
Project: 
Drupal core
Introduced in branch: 
10.4.x, 11.1.x
Introduced in version: 
10.4.1, 11.1.0
Issue links: 
https://www.drupal.org/node/3462829
Description: 

The navigation schema was storing the file ID for the custom logo. This could cause inconsistencies between different environments, and make it difficult to modify the logo directly from the file system. To avoid this, the file path, instead of the ID, is stored in the schema. This is the same as what theme settings does for the logo.

Before
Schema file:

navigation.settings:
  type: config_object
  label: 'Navigation settings'
  constraints:
    FullyValidatable: ~
  mapping:
    logo:
      type: mapping
      label: 'Logo settings'
      mapping:
        provider:
          type: string
          label: 'Select Navigation logo handling'
          constraints:
            Choice:
              - default
              - hide
              - custom
        managed:
          type: integer
          label: 'Custom logo'
          nullable: true
          constraints:
            Range:
              min: 0
        max:
          type: mapping
          label: 'Logo maximum settings'
          mapping:
            filesize:
              type: integer
              label: 'Maximum file sizes (bytes)'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
            height:
              type: integer
              label: 'Logo expected height'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
            width:
              type: integer
              label: 'Logo expected width'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
          constraints:
            ValidKeys: '<infer>'
      constraints:
        ValidKeys: '<infer>'

Config file:

logo:
  provider: default
  managed: 759
  max:
    filesize: 1048576
    height: 40
    width: 40

After
Schema file:

navigation.settings:
  type: config_object
  label: 'Navigation settings'
  constraints:
    FullyValidatable: ~
  mapping:
    logo:
      type: mapping
      label: 'Logo settings'
      mapping:
        provider:
          type: string
          label: 'Select Navigation logo handling'
          constraints:
            Choice:
              - default
              - hide
              - custom
        path:
          type: string
          label: 'Path'
          constraints:
            NotNull: [ ]
        max:
          type: mapping
          label: 'Logo maximum settings'
          mapping:
            filesize:
              type: integer
              label: 'Maximum file sizes (bytes)'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
            height:
              type: integer
              label: 'Logo expected height'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
            width:
              type: integer
              label: 'Logo expected width'
              constraints:
                NotNull: [ ]
                Range:
                  min: 0
          constraints:
            ValidKeys: '<infer>'
      constraints:
        ValidKeys: '<infer>'

Config file:

logo:
  provider: default
  path: 'public://navigation-logo.png'
  max:
    filesize: 1048576
    height: 40
    width: 40
Impacts: 
Module developers