GitLab CI reports PHP_CodeSniffer errors/warnings which should be fixed.

CommentFileSizeAuthor
#11 after.png30.29 KBgaurav gupta
#11 before.png200.01 KBgaurav gupta

Issue fork matomo-3478857

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

alyaj2a created an issue. See original summary.

alyaj2a’s picture

alyaj2a commented
Assigned: Unassigned » alyaj2a

alyaj2a opened merge request !61

alyaj2a’s picture

alyaj2a commented
Assigned: alyaj2a » Unassigned
Status: Active » Needs review
avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Status: Needs review » Needs work

There are still PHP_CodeSniffer errors/warnings to fix.

avpaderno opened merge request !62

avpaderno changed the visibility of the branch 3478857-gitlab-ci-reports to hidden.

divyansh.gupta’s picture

divyansh.gupta commented
Assigned: Unassigned » divyansh.gupta
divyansh.gupta’s picture

divyansh.gupta commented
Assigned: divyansh.gupta » Unassigned
Status: Needs work » Needs review

Solved Some more PHPCS errors.

avpaderno’s picture

avpaderno
he/him
Primary language Italian
Location Brescia, 🇮🇹 🇪🇺
commented
Issue summary: View changes
gaurav gupta’s picture

gaurav gupta commented
StatusFileSize
new before.png200.01 KB
new after.png30.29 KB

Hello,
i have tested the MR before and after .
All the coding standards issues has been solved.
Thanks.

gaurav gupta’s picture

gaurav gupta commented
Status: Needs review » Reviewed & tested by the community
grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: Unassigned » grimreaper

grimreaper closed merge request !61

grimreaper’s picture

grimreaper
Primary language French
Location France 🇫🇷
commented
Assigned: grimreaper » Unassigned
Status: Reviewed & tested by the community » Fixed

Hello,

After rebase, the MR has no more changes. It had been fixed in the issues I recently merged.

Marking as fixed and crediting contributors for the effort even without commit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.