Closed (fixed)
Project:
Simplenews
Version:
4.x-dev
Component:
Code
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Reporter:
Created:
4 Oct 2024 at 19:04 UTC
Updated:
21 Feb 2025 at 07:04 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #3
davps commentedComment #4
davps commentedI added a basic implementation and one operation "Delete subscriber" for example.
We need to discuss what other operations are needed. Maybe new operations can be done in other tasks so as not to block the current one.
Comment #5
adamps commentedGreat I really like the idea.
1) My main concern is that the fix adds a lot of lines of code - and already this module has way too much code to easily maintain. I would like to check if all this code is really necessary, or if there could be a simpler solution. I looked at Core, and I see that Node.php is similar to what you did, but Media and User entities are simpler.
2) It would be great to have a test of the bulk function.
Thanks
Comment #6
davps commented@adamps, thanks for the comments. I reviewed the code and agree that it could have been made simpler. I have updated the current version of the code.
I think existing users should get the new changes as well as new users. I removed these changes to make it simpler.
Added.
Comment #7
adamps commentedGreat thanks