Problem/Motivation

Add bulk operation feature for subscribers view. We need to discuss what kind of operations we want to see. There is no exact list yet.

User interface changes

Subscribers view will be updated.

CommentFileSizeAuthor
#4 3478840-4.png46.26 KBdavps

Issue fork simplenews-3478840

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

Comments

davps created an issue. See original summary.

davps’s picture

Issue summary: View changes
davps’s picture

Status: Active » Needs review
StatusFileSize
new46.26 KB

I added a basic implementation and one operation "Delete subscriber" for example.

-

We need to discuss what other operations are needed. Maybe new operations can be done in other tasks so as not to block the current one.

adamps’s picture

Status: Needs review » Needs work

Great I really like the idea.

1) My main concern is that the fix adds a lot of lines of code - and already this module has way too much code to easily maintain. I would like to check if all this code is really necessary, or if there could be a simpler solution. I looked at Core, and I see that Node.php is similar to what you did, but Media and User entities are simpler.

  1. SubscriberBulkForm is identical to BulkForm so do we really need it?
  2. Media.php doesn't have anything in the routing file, and it uses the default DeleteMultipleForm without overriding. Do we definitely need these parts?
  3. Maybe we don't need to alter existing views in the update hook - some sites might even prefer not to have a bulk action.

2) It would be great to have a test of the bulk function.

Thanks

davps’s picture

Status: Needs work » Needs review

1) My main concern is that the fix adds a lot of lines of code - and already this module has way too much code to easily maintain. I would like to check if all this code is really necessary, or if there could be a simpler solution. I looked at Core, and I see that Node.php is similar to what you did, but Media and User entities are simpler.

@adamps, thanks for the comments. I reviewed the code and agree that it could have been made simpler. I have updated the current version of the code.

Maybe we don't need to alter existing views in the update hook - some sites might even prefer not to have a bulk action.

I think existing users should get the new changes as well as new users. I removed these changes to make it simpler.

2) It would be great to have a test of the bulk function.

Added.

adamps’s picture

Status: Needs review » Fixed

Great thanks

  • adamps committed 5618a758 on 4.x authored by davps
    Issue #3478840 by davps, adamps: Add bulk operations to subscriber view
    

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.