Problem/Motivation

Duplicate error messages are added to all fields in the fieldset when submitting a node edit form with an end date before the start.

This also shows the hidden duration field with error messages.

Steps to reproduce

  • Create the smart date field.
  • In the field settings set the allowed duration values to 'custom' and default duration to 0.
  • Fill out a node edit form and all mandatory fields.
  • Add an end date that is before the start date.
  • Save the node edit form.
  • User is presented with error messages on each of the fields in the smart date fieldset.

Proposed resolution

Only show the error message on the end date field as it is where the error originates and it makes it clearer to the author.

CommentFileSizeAuthor
#7 3477741-fix.patch819 byteswilliamsona
#5 end_date_3477741.patch1.13 KBwilliamsona
#4 end_date_error_3477741.patch1.1 KBwilliamsona
#3 Screenshot 2024-09-30 at 11.48.00.png94.36 KBwilliamsona
Screenshot 2024-09-30 at 11.36.25.png135.72 KBwilliamsona

Issue fork smart_date-3477741

Command icon Show commands

Start within a Git clone of the project using the version control instructions.

Or, if you do not have SSH keys set up on git.drupalcode.org:

About issue forks

Comments

williamsona created an issue. See original summary.

williamsona opened merge request !150

williamsona’s picture

williamsona commented
Issue summary: View changes
StatusFileSize
new Screenshot 2024-09-30 at 11.48.00.png94.36 KB

Screenshot to show the error message restricted to the end value after the code change.

williamsona’s picture

williamsona commented
StatusFileSize
new end_date_error_3477741.patch1.1 KB
williamsona’s picture

williamsona commented
StatusFileSize
new end_date_3477741.patch1.13 KB
williamsona’s picture

williamsona commented
williamsona’s picture

williamsona commented
StatusFileSize
new 3477741-fix.patch819 bytes
mortona2k’s picture

mortona2k commented
Related issues: +#3385720: Implement errorElement() in Widgets

Related, and possibly duplicate issue.

mandclu’s picture

mandclu commented
Status: Active » Closed (duplicate)

Confirmed that this was fixed as part of the work done in #3385720: Implement errorElement() in Widgets. Thanks for the work here.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.