install.core.inc users a string literal for the locale server_pattern. That constant is also defined in the locale.module, so we should use that constant instead.
The below works as expected. Configuration is applied in the last step.
In addition to this, when installing Drupal from an existing configuration folder, locale config is completely ignored (ie: import_enabled or use_source).
The two things are connected because install.core.inc is hardcoding the values and not reading them from other places.
Use locale.module constant instead of hardcoding the value.
MR
| Comment | File | Size | Author |
|---|---|---|---|
| #5 | 3477277-nr-bot.txt | 90 bytes | needs-review-queue-bot |
Show commandsStart within a Git clone of the project using the version control instructions.
Or, if you do not have SSH keys set up on git.drupalcode.org:
changes
Comments
Comment #3
fjgarlin commentedThe configuration part is a non-issue, as it is applied later in the process, so the only issue is just duplicating the constant in code.
This can be either a really easy fix or a won't fix, but I'll put it for review in any case.
Comment #4
smustgrave commentedSeems straight forward enough.
Comment #5
needs-review-queue-bot commentedThe Needs Review Queue Bot tested this issue. It no longer applies to Drupal core. Therefore, this issue status is now "Needs work".
This does not mean that the patch necessarily needs to be re-rolled or the MR rebased. Read the Issue Summary, the issue tags and the latest discussion here to determine what needs to be done.
Consult the Drupal Contributor Guide to find step-by-step guides for working with issues.
Comment #6
fjgarlin commentedJust did a rebase. Back to RTBC.
Comment #7
alexpottLet's move the constant. This is something we need earlier than the module system being available because we download translations in the very very early installer. Therefore let's deprecate LOCALE_TRANSLATION_DEFAULT_SERVER_PATTERN and move the constant to \Drupal::TRANSLATION_DEFAULT_SERVER_PATTERN or somewhere else. Including all the locale module code throughout the installation process doesn't feel the correct approach.
Comment #9
sourav_paulComment #10
fjgarlin commentedI made a comment in the MR, it still needs some minor clean up.
Comment #11
fjgarlin commentedI made MR suggestions for the code to address my feedback and @alexpott's feedback.
Comment #12
fjgarlin commentedThe @deprecate tag seems to require a change record node to be created.
Comment #13
fjgarlin commentedChange record created, I'm not sure if this is the expected format: https://www.drupal.org/node/3488133
Comment #14
arunkumarkComment #15
smustgrave commentedMost likely missed 11.1 window mind updating for 11.2, @fjgarlin feel free to ping me to re-look at quicker for you.
Comment #19
fjgarlin commentedWhen rebasing, it was getting a conflict on files that were not modified by this MR, so rather than going into a rabbit hole, I created a new branch/MR with the same changes: https://git.drupalcode.org/project/drupal/-/merge_requests/10419 (old MR for reference)
As per #15, I'll ping @smustgrave for review.
Comment #21
smustgrave commentedManually updated deprecation for 11.2 but rest seems good.
Comment #22
alexpottCommitted 95cfe64 and pushed to 11.x. Thanks!