also in the -unstable version, the now playing block show the title i gave it but no content

CommentFileSizeAuthor
#4 station_347665.patch2.1 KBdrewish
#2 station_347665.patch1.15 KBtim.plunkett
#1 station_module.patch575 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new station_module.patch575 bytes

My PHP isn't stellar, but I think the issue is that it attempts to retrieve the current program and also checks to see if the program is valid, in the same step.
I broke it into two if statements, see the attached patch.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new station_347665.patch1.15 KB

I found another issue with the station block, this time with the streams.
I "fixed" it, but I'm not sure that I've gone about it properly.
See attached!
- Tim

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Component: Programs » Other

this revision is the culprit.

drewish’s picture

drewish commented
StatusFileSize
new station_347665.patch2.1 KB

The first part of the patch is correct but the second part isn't quite right. The fix needs to go in upstream in station_schedule_get_list().

Could you review this patch?

drewish’s picture

drewish commented
Status: Needs review » Fixed

I'm pretty happy with this patch. Committed to HEAD.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.